[MGNLUI-1526] Forcing application restart throws exception Created: 03/Jun/13  Updated: 14/Jun/13  Resolved: 04/Jun/13

Status: Closed
Project: Magnolia UI
Component/s: None
Affects Version/s: 5.0
Fix Version/s: 5.0

Type: Bug Priority: Neutral
Reporter: Samuli Penttilä Assignee: Aleksandr Pchelintcev
Resolution: Fixed Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Issue Links:
relation
is related to MAGNOLIA-5077 Stabilize UITests Closed
supersession
supersedes MGNLUI-1532 Logging out results in NPE Closed
Template:
Acceptance criteria:
Empty
Task DoD:
[ ]* Doc/release notes changes? Comment present?
[ ]* Downstream builds green?
[ ]* Solution information and context easily available?
[ ]* Tests
[ ]* FixVersion filled and not yet released
[ ]  Architecture Decision Record (ADR)
Bug DoR:
[ ]* Steps to reproduce, expected, and actual results filled
[ ]* Affected version filled
Date of First Response:
Sprint: RC 1

 Description   

Server console is filled with exceptions when applying ?restartApplication to the url while a dialog is opened in Pages app.

Steps to reproduce:
1. Open Pages App and edit any page
2. Edit page properties to open a modal dialog
3. Enter URL in browser containing the ?restartApplication parameter
4. Admincentral seems to be working, but console is filled with exceptions and warnings.

[INFO] [talledLocalContainer] 2013-06-03 13:27:22,196 WARN info.magnolia.event.SimpleEventBus : Exception caught when dispatching event: null
[INFO] [talledLocalContainer] java.lang.NullPointerException
[INFO] [talledLocalContainer] at info.magnolia.ui.vaadin.magnoliashell.MagnoliaShell.showError(MagnoliaShell.java:139)
[INFO] [talledLocalContainer] at info.magnolia.ui.framework.shell.ShellImpl.messageSent(ShellImpl.java:239)
[INFO] [talledLocalContainer] at info.magnolia.ui.framework.message.MessageEvent.dispatch(MessageEvent.java:56)
[INFO] [talledLocalContainer] at info.magnolia.ui.framework.message.MessageEvent.dispatch(MessageEvent.java:41)
[INFO] [talledLocalContainer] at info.magnolia.event.SimpleEventBus.fireEvent(SimpleEventBus.java:78)
[INFO] [talledLocalContainer] at info.magnolia.ui.framework.message.LocalMessageDispatcher.messageSent(LocalMessageDispatcher.java:57)
[INFO] [talledLocalContainer] at info.magnolia.ui.framework.message.MessagesManagerImpl.sendMessageSentEvent(MessagesManagerImpl.java:180)
[INFO] [talledLocalContainer] at info.magnolia.ui.framework.message.MessagesManagerImpl.sendLocalMessage(MessagesManagerImpl.java:112)
[INFO] [talledLocalContainer] at info.magnolia.ui.admincentral.AdmincentralErrorHandler.error(AdmincentralErrorHandler.java:71)
[INFO] [talledLocalContainer] at info.magnolia.ui.admincentral.AdmincentralUI.detach(AdmincentralUI.java:119)
[INFO] [talledLocalContainer] at com.vaadin.ui.UI.setSession(UI.java:344)
[INFO] [talledLocalContainer] at com.vaadin.server.VaadinSession.removeUI(VaadinSession.java:626)
[INFO] [talledLocalContainer] at com.vaadin.server.VaadinService.fireSessionDestroy(VaadinService.java:340)
[INFO] [talledLocalContainer] at com.vaadin.server.VaadinSession.valueUnbound(VaadinSession.java:181)
[INFO] [talledLocalContainer] at org.mortbay.jetty.servlet.AbstractSessionManager$Session.unbindValue(AbstractSessionManager.java:1133)
[INFO] [talledLocalContainer] at org.mortbay.jetty.servlet.AbstractSessionManager$Session.removeAttribute(AbstractSessionManager.java:1027)
[INFO] [talledLocalContainer] at org.mortbay.jetty.servlet.AbstractSessionManager$Session.setAttribute(AbstractSessionManager.java:1053)

[WARNING] [talledLocalContainer] WARNING: Unregistered Label (115) that was already unregistered.
[WARNING] [talledLocalContainer] Jun 3, 2013 1:27:22 PM com.vaadin.ui.ConnectorTracker unregisterConnector



 Comments   
Comment by Samuli Penttilä [ 04/Jun/13 ]

This particular stack trace reveals that this has something to do with Form. While debugging it is the first TextField in a Dialog containing a Form that throws error while detaching.

2013-06-04 09:54:55,303 ERROR .magnolia.ui.admincentral.AdmincentralErrorHandler: AdmincentralUI has encountered an unhandled exception.
java.lang.NullPointerException
at com.vaadin.server.AbstractClientConnector.detach(AbstractClientConnector.java:624)
at com.vaadin.ui.AbstractComponent.detach(AbstractComponent.java:567)
at com.vaadin.ui.AbstractField.detach(AbstractField.java:1363)
at com.vaadin.server.AbstractClientConnector.detach(AbstractClientConnector.java:619)
at com.vaadin.ui.AbstractComponent.detach(AbstractComponent.java:567)
at com.vaadin.server.AbstractClientConnector.detach(AbstractClientConnector.java:619)
at com.vaadin.ui.AbstractComponent.detach(AbstractComponent.java:567)
at com.vaadin.server.AbstractClientConnector.detach(AbstractClientConnector.java:619)
at com.vaadin.ui.AbstractComponent.detach(AbstractComponent.java:567)
at com.vaadin.server.AbstractClientConnector.detach(AbstractClientConnector.java:619)
at com.vaadin.ui.AbstractComponent.detach(AbstractComponent.java:567)
at com.vaadin.server.AbstractClientConnector.detach(AbstractClientConnector.java:619)
at com.vaadin.ui.AbstractComponent.detach(AbstractComponent.java:567)
at com.vaadin.server.AbstractClientConnector.detach(AbstractClientConnector.java:619)
at com.vaadin.ui.AbstractComponent.detach(AbstractComponent.java:567)
at com.vaadin.server.AbstractClientConnector.detach(AbstractClientConnector.java:619)
at com.vaadin.ui.AbstractComponent.detach(AbstractComponent.java:567)
at com.vaadin.server.AbstractClientConnector.detach(AbstractClientConnector.java:619)
at com.vaadin.ui.AbstractComponent.detach(AbstractComponent.java:567)
at com.vaadin.server.AbstractClientConnector.detach(AbstractClientConnector.java:619)
at com.vaadin.ui.AbstractComponent.detach(AbstractComponent.java:567)
at com.vaadin.ui.UI.detach(UI.java:1024)
at info.magnolia.ui.admincentral.AdmincentralUI.detach(AdmincentralUI.java:119)
at com.vaadin.ui.UI.setSession(UI.java:344)
at com.vaadin.server.VaadinSession.removeUI(VaadinSession.java:626)
at com.vaadin.server.VaadinService.fireSessionDestroy(VaadinService.java:340)

Comment by Aleksandr Pchelintcev [ 04/Jun/13 ]

In order to avoid overlay memory leaks we introduced the overlay parent detach listener that would cause an overlay to be removed from MagnoliaShell. In case of ?restartApplication refresh, log out or any reason for a session to die and UI to be detached - there seems to be a conflict between a leak prevention and the recursive clearing of UI's child components. See the superseded ticket for the related commit.

Generated at Mon Feb 12 08:47:28 CET 2024 using Jira 9.4.2#940002-sha1:46d1a51de284217efdcb32434eab47a99af2938b.