- AbstractItemSubApp, ItemLocation, EditItemAction, ItemPresenter, ItemViewImpl and LOTS of others
- class level javadoc
- It seems you have set a template to generate class level javadoc like that to avoid having failures from checkstyle. This is wrong. We use checkstyle to make sure that our code is well documented not to play hide and seek and check who can better fool the tool.
- ItemPresenter.initContentView()
- lot's of commented out code - should be removed completely if it is not used
- FormDialogPresenterImpl
- do not leave in commented out code. Either it is useless and should be removed or it is a temporary workaround and should be documented and removed when ticket is solved.
- ItemWorkbenchPresenter
- do not leave in commented out code. Either it is useless and should be removed or it is a temporary workaround and should be documented and removed when ticket is solved.
- ItemWorkbenchViewImpl
- this seems wrong ... if there is a reason for returning null, it should be explain in javadoc or in inline comment
- config.modules.ui-admincentral.workbenchActionRegistry.xml
- EditItemAction
- do not print stack trace like this ... ever. Since you have AEE in the signature you should rethrow RepoEx as AEE
- EditItemActionDefinition, ContactsItemView
- completely empty interface ... why? Javadoc is necessary to explain it
|