[MGNLUI-1647] Release profiles - GWT compile in "production" mode and skip Clover for widgets and widgetsets modules Created: 13/Jun/13  Updated: 24/Jun/13  Resolved: 13/Jun/13

Status: Closed
Project: Magnolia UI
Component/s: None
Affects Version/s: 5.0
Fix Version/s: 5.0

Type: Task Priority: Blocker
Reporter: Magnolia International Assignee: Magnolia International
Resolution: Fixed Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Issue Links:
causality
caused by BUILD-124 Skipping Clover on releases does not ... Closed
Template:
Acceptance criteria:
Empty
Task DoR:
Empty
Sprint: RC 2

 Description   

I was a little too eager to "properly" disable Clover (as per BUILD-110), and realized this actually did not work for submodules of reactor projects.

What happens is that the additionalReleaseProfiles is used to configure the release plugin... in the parent poms. Setting that property in a submodule is unfortunately too late.

Proposed fix:

  • enable the gwt-production-mode profile via additionalReleaseProfiles from the parent (even if the profile is defined in a submodule)
  • disable clover the old-fashioned way via pluginManagement in magnolia-ui-vaadin-common-widgets and magnolia-ui-vaadin-widgetset


 Comments   
Comment by Magnolia International [ 13/Jun/13 ]

Not too happy about the fix. See BUILD-124 for improvements.

Generated at Mon Feb 12 08:48:40 CET 2024 using Jira 9.4.2#940002-sha1:46d1a51de284217efdcb32434eab47a99af2938b.