[MGNLUI-1717] Default dialog action should not have to be called commit Created: 18/Sep/12 Updated: 10/Mar/21 Resolved: 10/Mar/21 |
|
| Status: | Closed |
| Project: | Magnolia UI |
| Component/s: | dialogs |
| Affects Version/s: | None |
| Fix Version/s: | None |
| Type: | Bug | Priority: | Neutral |
| Reporter: | Tobias Mattsson | Assignee: | Unassigned |
| Resolution: | Obsolete | Votes: | 0 |
| Labels: | None | ||
| Remaining Estimate: | Not Specified | ||
| Time Spent: | Not Specified | ||
| Original Estimate: | Not Specified | ||
| Template: |
|
| Acceptance criteria: |
Empty
|
| Task DoD: |
[ ]*
Doc/release notes changes? Comment present?
[ ]*
Downstream builds green?
[ ]*
Solution information and context easily available?
[ ]*
Tests
[ ]*
FixVersion filled and not yet released
[ ] 
Architecture Decision Record (ADR)
|
| Bug DoR: |
[ ]*
Steps to reproduce, expected, and actual results filled
[ ]*
Affected version filled
|
| Description |
|
We are assigned a class to the dialog action based on its name, btn-dialog-cancel, btn-dialog-commit etc. The class btn-dialog-commit adds a different color and makes the button move to the right and adds space between the buttons by adding a margin. We should rather have a style that makes the dialog appear as the default action by changing its color. Marking the action as the default/primary oen should be a boolean configurable in the repo. Spacing needs to be there for all buttons. The order of the buttons should be the same as the order of their definitions in the repository. |