[MGNLUI-1790] Item of JcrNewNodeAdapter should point the newly created node after applying changes (not to parent node) Created: 27/Jun/13  Updated: 05/Jul/13  Resolved: 04/Jul/13

Status: Closed
Project: Magnolia UI
Component/s: app framework
Affects Version/s: 5.0
Fix Version/s: 5.0.1

Type: Bug Priority: Major
Reporter: Philip Mundt Assignee: Philip Mundt
Resolution: Fixed Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Issue Links:
Relates
relates to MGNLUI-606 info.magnolia.ui.vaadin.integration.j... Closed
dependency
is depended upon by MGNLUI-1005 Newly created content (Asset/Category... Closed
Template:
Acceptance criteria:
Empty
Task DoD:
[ ]* Doc/release notes changes? Comment present?
[ ]* Downstream builds green?
[ ]* Solution information and context easily available?
[ ]* Tests
[ ]* FixVersion filled and not yet released
[ ]  Architecture Decision Record (ADR)
Bug DoR:
[ ]* Steps to reproduce, expected, and actual results filled
[ ]* Affected version filled
Date of First Response:

 Description   

After creating a new JcrNewNodeAdapter item and applying changes, the item will still point to the parent node. It should point to the new node.

Additionally, calling applyChanges() twice should behave correctly: after creation of the node, apply changes should behave like JcrNodeAdapter.applyChanges().



 Comments   
Comment by Espen Jervidalo [ 27/Jun/13 ]

info.magnolia.ui.vaadin.integration.jcr.JcrNodeAdapterTest
please add test cases as discussed:
– checking changedProperties before and after applyChanges
– one to verify you don't get the parent after applychanges

JcrNewNodeAdapter
add empty line after log field
#applyChanges() more javadoc explaining that the item changes from parent to new node after this function
#getItemProperty(propertyId) javadoc explaining why we override this method -> otherwise it would get the property from the parent node

Comment by Philip Mundt [ 04/Jul/13 ]

Hole package might need some future adjustments.

Generated at Mon Feb 12 08:50:10 CET 2024 using Jira 9.4.2#940002-sha1:46d1a51de284217efdcb32434eab47a99af2938b.