[MGNLUI-1832] Show an unsupported browser page when no widgetset is available Created: 12/Jul/13 Updated: 16/Aug/13 Resolved: 16/Jul/13 |
|
| Status: | Closed |
| Project: | Magnolia UI |
| Component/s: | user interaction |
| Affects Version/s: | 5.0.1 |
| Fix Version/s: | 5.1 |
| Type: | New Feature | Priority: | Major |
| Reporter: | Mikaël Geljić | Assignee: | Mikaël Geljić |
| Resolution: | Fixed | Votes: | 0 |
| Labels: | None | ||
| Remaining Estimate: | Not Specified | ||
| Time Spent: | Not Specified | ||
| Original Estimate: | Not Specified | ||
| Attachments: |
|
| Template: |
|
| Acceptance criteria: |
Empty
|
| Date of First Response: |
| Description |
|
Currently, when we try to login in a browser for which we don't compile the widgetset (e.g. iPhone, IE8), we end up with an ever-loading indicator. We should get a decent message that browser is not supported instead. More details on browser support on feature status page http://wiki.magnolia-cms.com/display/DEV/Widgetset+and+browser+support |
| Comments |
| Comment by Mikaël Geljić [ 15/Jul/13 ] |
|
Added unsupported browser page when widgetset was not compiled for current browser and results in trying to fetch undefined.cache.js. Since this happens in a javascript request, we wrap the response as a js innerHTML assignment on document body. As a side QA task, I enabled the 500 error page not only for GET requests but also for POST (e.g. after login). |
| Comment by Mikaël Geljić [ 16/Jul/13 ] |
|
first closed, then reopened it myself just to push it properly to acceptance |
| Comment by Andreas Weder [ 17/Jul/13 ] |
|
Looks good, I would only like to see some text changes.
|
| Comment by Andreas Weder [ 18/Jul/13 ] |
|
Just checked the new screen shot you've uploaded. May I ask you to group the apology with the second paragraph? This is about first saying what when wrong, in a single sentence. In the second paragraph, we apologize and offer a way our of it. Actually, now that I think of it, we should put the apology at the end really, so like this:
You're trying to use Magnolia 5 on a browser we currently do not support. Please log in using either Firefox, Chrome, Safari or IE 9+. We apologize for any inconvenience caused. |
| Comment by Mikaël Geljić [ 18/Jul/13 ] |
|
updated again and pushed to master, hudson will tell |
| Comment by Andreas Weder [ 18/Jul/13 ] |
|
Thanks, looks good to me now. Should I find anything still, I'll file another issue. |