[MGNLUI-1836] Style favorites and their editing UI according to the style guides Created: 15/Jul/13  Updated: 16/Aug/13  Resolved: 29/Jul/13

Status: Closed
Project: Magnolia UI
Component/s: favorites
Affects Version/s: None
Fix Version/s: 5.1

Type: Improvement Priority: Major
Reporter: Andreas Weder Assignee: Federico Grilli
Resolution: Fixed Votes: 0
Labels: design
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Issue Links:
supersession
is superseded by MGNLUI-1880 Fix a set of style and behavior issue... Closed
Template:
Acceptance criteria:
Empty
Task DoD:
[ ]* Doc/release notes changes? Comment present?
[ ]* Downstream builds green?
[ ]* Solution information and context easily available?
[ ]* Tests
[ ]* FixVersion filled and not yet released
[ ]  Architecture Decision Record (ADR)
Date of First Response:

 Description   

Favorites already look quite good, but work still needs to be done for them to match the style guide.

  • Make sure that the "add favorite"/"add group" dialog is properly styled
  • Define the light gray hover style for favorites and group titles.
  • Ensure that selected elements look as defined (e.g. less high). Elements, in general, look bulkier and coarse, please verify font sizes, dimensions, margins and paddings.
  • When editing, the edited text should be on a white background and bordered with light blue lines (as all form field in focus).


 Comments   
Comment by Andreas Weder [ 15/Jul/13 ]

Linking definitions from the style guide, which show quite precisely, how the Favorites shell app is supposed to look.

Comment by Federico Grilli [ 29/Jul/13 ]

Looks fine on latest FF, Safari and Chrome.

Comment by Andreas Weder [ 02/Aug/13 ]

I've done acceptance - there's still quite a number of things we have to look at. I'll create a follow up story issue to make sure we track that properly

I've created a review page capturing all issues: http://wiki.magnolia-cms.com/display/UX/State+of+Favorites

On a site note, and no offense meant: the idea of this issue was actually to fix most of the styling problems I've recorded on the above page right away. However, I've come to realize that it's not easy to see what is wrong without an actual, detailed list. I'm not sure how we will handle cases like this in the future as I can't spend an afternoon doing reviews requiring a lot of work to compile. Nevertheless, the reviews have to be done. This might be an indication that we have to grow the design time in the near future.

Generated at Mon Feb 12 08:50:37 CET 2024 using Jira 9.4.2#940002-sha1:46d1a51de284217efdcb32434eab47a99af2938b.