Upgrade to Vaadin 7.1 (MGNLUI-1843)

[MGNLUI-1855] Default converter doesn't work with Long property (Vaadin 7.1) Created: 19/Jul/13  Updated: 16/May/14  Resolved: 22/Jul/13

Status: Closed
Project: Magnolia UI
Component/s: dialogs, forms
Affects Version/s: None
Fix Version/s: 5.1

Type: Sub-task Priority: Major
Reporter: Mikaël Geljić Assignee: Mikaël Geljić
Resolution: Fixed Votes: 0
Labels: vaadin7.1
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Issue Links:
causality
is causing MGNLUI-2033 Cannot edit Long properties Closed
relation
is related to MGNLUI-2902 Stacktrace in dialog by failed Long c... Closed
Template:

 Description   

Converter is not working at all.

1. Go to contacts app
2. Edit leo
3. Save changes

=> Please correct the 1 errors in this form [Jump to next error]
=> next to ZIP field: Could not convert value to Number

Even though ZIP code is not required.

4. Fill in ZIP code
=> same error: Could not convert value to Number



 Comments   
Comment by Mikaël Geljić [ 22/Jul/13 ]

This is a bug in Vaadin 7.1; StringToNumberConverter doesn't work with Long properties:

  • The DefaultConverterFactory finds that the Number type is assignable from Long (L106) and returns a StringToNumberConverter. So far so good.
  • However since 7.1, the StringToNumberConverter does a strict comparison between targetType (Long) and model type (Number), and throws a ConversionException.

Forum thread: https://vaadin.com/fr/forum#!/thread/3661280
Vaadin ticket: http://dev.vaadin.com/ticket/12225

Fix is planned for Vaadin 7.2.

In the meantime, we'll have our own StringToLongConverter (preferably not in a visible scope, so that we can freely get rid of it at a later point in time).

Generated at Mon Feb 12 08:50:48 CET 2024 using Jira 9.4.2#940002-sha1:46d1a51de284217efdcb32434eab47a99af2938b.