Upgrade to Vaadin 7.1 (MGNLUI-1843)

[MGNLUI-1857] Review where Overlays are attached Created: 19/Jul/13  Updated: 16/Aug/13  Resolved: 23/Jul/13

Status: Closed
Project: Magnolia UI
Component/s: None
Affects Version/s: None
Fix Version/s: 5.1

Type: Sub-task Priority: Major
Reporter: Mikaël Geljić Assignee: Mikaël Geljić
Resolution: Not an issue Votes: 0
Labels: vaadin7.1
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Template:

 Description   

Following UI tests are failing:

  • sendAndRetrieveMessage
  • sendAndRetrieveErrorMessage

Those messages may appear at an unexpected location in the DOM tree - UI tests would fail when trying to find corresponding WebElements.

Might be related to the following error message that sometimes appears in Vaadin 7.1 debug console (e.g. when using ContextMenu):
Could not determine ApplicationConnection for Overlay. Overlay will be attached directly to the root panel



 Comments   
Comment by Mikaël Geljić [ 23/Jul/13 ]
  • The 2 failing tests mentioned above might have been side-effects of the converter issue (MGNLUI-1855). Those failures no longer appear once it is fixed.
  • As for the debug message between ApplicationConnection and Overlay, here Overlay stands for the Vaadin VOverlay, i.e. not what we call overlays for e.g. displaying modal dialogs on top of the magnolia shell. Besides, the message is caused by the ContextMenu addon (that is currently forked in common-widgets module), see VPopupImpl#onShow. I reckon they do expect the root panel to be returned so that the context menu sits on top of everything else. Finally, and most importantly, it was already the same in Vaadin 7.0.x.
Generated at Mon Feb 12 08:50:49 CET 2024 using Jira 9.4.2#940002-sha1:46d1a51de284217efdcb32434eab47a99af2938b.