[MGNLUI-186] Thumbnail view should show icons for nodes that are not images. Created: 09/Nov/12 Updated: 11/Feb/13 Resolved: 27/Nov/12 |
|
| Status: | Closed |
| Project: | Magnolia UI |
| Component/s: | None |
| Affects Version/s: | None |
| Fix Version/s: | 5.0 |
| Type: | New Feature | Priority: | Neutral |
| Reporter: | Christopher Zimmermann | Assignee: | Christopher Zimmermann |
| Resolution: | Fixed | Votes: | 0 |
| Labels: | None | ||
| Remaining Estimate: | Not Specified | ||
| Time Spent: | Not Specified | ||
| Original Estimate: | Not Specified | ||
| Issue Links: |
|
||||||||||||||||||||
| Template: |
|
||||||||||||||||||||
| Acceptance criteria: |
Empty
|
||||||||||||||||||||
| Date of First Response: | |||||||||||||||||||||
| Description |
|
pdf, audio, video should all serve icon images from admincentral theme. |
| Comments |
| Comment by Christopher Zimmermann [ 12/Nov/12 ] |
|
Its working - but: Need to clean up how path is created to icons in ThumbnailContainerProperty.getValue(). |
| Comment by Jan Haderka [ 15/Nov/12 ] |
|
This ticket is still in-progress so up-front appology if i bring up something you wanted to do anyway but:
|
| Comment by Christopher Zimmermann [ 23/Nov/12 ] |
|
I see the point about the MIMEMapping. But if you look at the new DefaultImageProvider.resolveIconClassName() method you can see that it is choosing icons based on the mime type, not on the extension. Which is valuable. |
| Comment by Christopher Zimmermann [ 23/Nov/12 ] |
|
DefaultImageProvider now returns a Resource which is either an ExternalResource if its able to generate an image file, or its an IconFontResource which contains the CssClassName for the icon which is appropriate for the type of document, based on the documents MimeType. In order to get DefaultImageProvider to create an IconFontResource it needed to be refactored and moved out of the magnolia.ui.model package where it did not belong. In model, it was renamed into ImageProviderDefinition and ConfiguredImageProviderDefinition to match the pattern of the other model classes. Where necessary other files were changed to use the ComponentProvider in order to instantiate the ImageProvider based on configuration. ActionBar was also updated to create an Icon when the resource is an IconFontResource. |
| Comment by Espen Jervidalo [ 30/Nov/12 ] |
|
Created a follow up ticket in s10. |