- FormDialogPresenterImpl
- pls use javadoc comment style in javadoc only. Inline comment here is perfectly appropriate.
- FormPresenterImpl
- if you are not going to provide info about params or return type don't even add this to javadoc. It will be generated empty in javadoc anyway.
- CreateItemAction
- while this kind of javadoc will make checkstyle to shut up, it's not enough for me.
- again either this is javadoc and should be placed in javadoc or it is an inline comment and should use inline comment style
- This is sooo wrong! Obviously Action could not be executed because of RepoException, so you should rethrow it as AEE and not just log in log files where no one will see it.
- CreateItemActionDefinition
- Class level javadoc is not correct.
- Also action def that uses appId, subAppId and NodeType seems to me like something that will be used around much more often then just to CreateItems so perhaps name should be more generic
- ItemWorkbenchPresenter
- thx for explanation, but is there a ticket for it created already? And really this is just a "TODO" w/o "TODO" so if you really need to leave it like this you should mark it as todo (And create ticket in jira)
- config.modules.ui-admincentral.workbenchActionRegistry.xml
- remove, no metadata should be in new bootstrap files
- SaveContactFormAction
- either this we need to do something about it, in which case it is TODO and there should be jira ticket or it is not a TODO, we plan to do nothing about it and it should be removed completely from the code
- else block just to make inline comment is terrible waste of space and your and compiler's time.
- we have already utilities in core to generate unique names. Why not reuse them rather then inventing your own code?
- CancelFormActionDefinition
- class level javadoc explaining why we need empty class implementing empty interface?
- FormActionFactoryImpl
- SaveFormActionDefinition
- class level javadoc
- this def defines only label and name. I doubt it is relevant only to save so it should be perhaps renames to something more generic
- ItemWorkbenchPresenter
- Why are you adding commented lines of code?
- ui-admincentral.xml
- why is ui-vaadin component defined in ui-admincentral and not in ui-vaadin?
- ContactsModule
- some field labels seems to be capitalized (Office Fax Nr) some not (Office phone) ... I don't really care which style you choose (pbly Antti or Andreas should say), but they need to be all written in same style
- button labels seem to be completely w/o capitalisation and all lower case
- SaveContactFormAction, SaveContactFormActionDefinition, FormActionBuilder, FormBuilder, FormConfig
- class level javadoc, btw 2nd class defines nothing ... why is it needed at all?
- in case i missed some class, all that have just name of the class w/ dot at the end as a javadoc need to be updated.
|