[MGNLUI-1876] Clean up and review the last static color definitions Created: 29/Jul/13  Updated: 19/Aug/13  Resolved: 07/Aug/13

Status: Closed
Project: Magnolia UI
Component/s: design
Affects Version/s: 5.0.1
Fix Version/s: 5.1

Type: Improvement Priority: Neutral
Reporter: Mikaël Geljić Assignee: Mikaël Geljić
Resolution: Fixed Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Template:
Acceptance criteria:
Empty
Task DoD:
[ ]* Doc/release notes changes? Comment present?
[ ]* Downstream builds green?
[ ]* Solution information and context easily available?
[ ]* Tests
[ ]* FixVersion filled and not yet released
[ ]  Architecture Decision Record (ADR)

 Description   

More than 60 static hexa color definitions could already be mapped to Sass variables, see c7db4364c9c8c8552117c70aa31f4e058dbc2b3e, but there are still a few out there which need to be sorted out:

  • The trinity icons will use the palette's darker green <30>, this makes them darker and a bit more green-ish, while it increases contrast.
  • There are 3 occurrences of unmapped colors in page-editor, check whether a replacement with the editor's palette can be done.
  • Button colors in light dialogs: they are specified with blend mode: multiply. We should see if the state of Sass support in Vaadin can help us compute these values.


 Comments   
Comment by Mikaël Geljić [ 07/Aug/13 ]

fixed colors for trinity icons and page-editor.
for light dialogs: Vaadin does not support custom Sass functions yet, although there are contributions ongoing. Only the built-ins 'lighten' and 'darken' are available so far, which does not match our needs.

Generated at Mon Feb 12 08:51:00 CET 2024 using Jira 9.4.2#940002-sha1:46d1a51de284217efdcb32434eab47a99af2938b.