[MGNLUI-1890] AbstractCommandAction should support multiple items Created: 08/Aug/13 Updated: 16/Aug/13 Resolved: 16/Aug/13 |
|
| Status: | Closed |
| Project: | Magnolia UI |
| Component/s: | framework |
| Affects Version/s: | None |
| Fix Version/s: | 5.1 |
| Type: | Task | Priority: | Neutral |
| Reporter: | Jozef Chocholacek | Assignee: | Jozef Chocholacek |
| Resolution: | Fixed | Votes: | 0 |
| Labels: | None | ||
| Remaining Estimate: | Not Specified | ||
| Time Spent: | Not Specified | ||
| Original Estimate: | Not Specified | ||
| Template: |
|
| Acceptance criteria: |
Empty
|
| Task DoR: |
Empty
|
| Date of First Response: |
| Comments |
| Comment by Christopher Zimmermann [ 16/Aug/13 ] |
|
Please add call to setCurrentItem on the first item in the default execute method in AbstractMultiItemAction. Otherwise callers always need to run this method. |
| Comment by Christopher Zimmermann [ 16/Aug/13 ] |
|
Changes are nice - but don't appear to address reason for ticket re-openification. See previous comment. If SetCurrentItem is called by default - then many callers wont have to call it. For example, look at the list of tests that call setCurrentItem now. I welcome discussion or reason why its better the way it is. |