[MGNLUI-1911] Move back applauncher configuration to ui-admincentral Created: 13/Aug/13  Updated: 03/Oct/13  Resolved: 10/Sep/13

Status: Closed
Project: Magnolia UI
Component/s: applauncher
Affects Version/s: 5.0.1
Fix Version/s: 5.1

Type: Task Priority: Major
Reporter: Mikaël Geljić Assignee: Christoph Meier
Resolution: Fixed Votes: 0
Labels: None
Remaining Estimate: 0.5d
Time Spent: Not Specified
Original Estimate: 0.5d

Issue Links:
causality
is causing MAGNOLIA-5356 Web.xml uses 2.5 and 3.0 features but... Closed
dependency
depends upon CNTCTSAPP-47 adapt to change of appLauncherLayout... Closed
depends upon MAGNOLIA-5295 adapt to change of appLauncherLayout ... Closed
depends upon MGNLADMLEG-22 adapt to change of appLauncherLayout ... Closed
depends upon MGNLCAT-91 adapt to change of appLauncherLayout ... Closed
depends upon MGNLCMNT-84 adapt to change of appLauncherLayout ... Closed
depends upon MGNLDAM-300 adapt to change of appLauncherLayout ... Closed
depends upon MGNLDATA-193 adapt to change of appLauncherLayout ... Closed
depends upon MGNLSTK-1235 adapt to change of appLauncherLayout ... Closed
Template:
Acceptance criteria:
Empty
Task DoR:
Empty
Release notes required:
Yes
Date of First Response:
Sprint: 5.1 Beta1- Frontend

 Description   

appLauncherLayout contentnode will now be in ui-admincentral instead of in ui-framework.

As agreed during widgetset concept review

  • update all bootstraps and update tasks
  • update iframe and contentapp wrapper tasks


 Comments   
Comment by Mikaël Geljić [ 30/Aug/13 ]

Realized appLauncherLayout config for configuration and security apps is currently bootstrapped in config.modules.ui-framework.config.appLauncherLayout.xml, which should just be the skeleton for the appLauncherLayout, without any app.

Please extract these two to their respective modules:

  • in magnolia-ui-admincentral: config.modules.ui-admincentral.config.appLauncherLayout.groups.manage.apps.configuration.xml
  • in magnolia-security-app: config.modules.ui-admincentral.config.appLauncherLayout.groups.manage.apps.security.xml

Ensure the ordering is still correct upon fresh install

Comment by Christoph Meier [ 30/Aug/13 ]

ok. i did

Comment by Christoph Meier [ 03/Sep/13 ]

there are branches on the remote-repo which contain all the changes.
Unfortunately,the name of the branch reflects the name of i ticket i created for this job before i realized, that THIS ticket exists.
=> Name of the branch: fix_MGNLUI-1972
(for magnolia_ui, magnolia_main, activation, admininterface-legacy, dam, data, contacts-app, categorization, standard-templating-kit)
BUT comments of the commits contain the number of THIS ticket (the usual comment is: "fixed MGNLUI-1911 (Move back applauncher configuration to ui-admincentral)")

Note: at least standard-templating-kit depends on magnolia 5.0.x, yet, but this ticket should be done for 5.1

the google-doc https://docs.google.com/document/d/1Pz5tWdoJD6LkwLdac2fueLoyTH7yXOnsQSTLkEv-rtI/edit gives an overview of the changes which have been made.
mainly, it is the follwoing things:

  • now, AdmincentralModule keeps the bean of the AppLauncherLayoutDefinition, get the AppLauncherLayoutManager (by injection) and AppLauncherLayoutDefinition is set to the AppLauncherLayoutManager (this was in UiFrameworkModule before; must have been removed)
  • lot of BootStrap-files changed their name (now with the path to admincentral)
  • the "skeleton" of the applauncherLayout moved form ui-framework to admincentral
  • some hardcoded strings with the path to the applauncher-layout-config has been changed in a couple of ModuleVersionHandler-classes
  • AdmincentralModuleVersionHandler has new Task for a DeltaBuilder.update("5.1") to move /modules/ui-framework/config/appLauncherLayout to /modules/ui-admincentral/config/appLauncherLayout
  • some new tests

although it has not been changed, STKModuleVersionHandlerTest now fails. Might have to do something with the versions ... i'm not quite sure.

to review this ticket, use the fix_MGNLUI-1972-branch(es)

Comment by Christoph Meier [ 03/Sep/13 ]

since Christopher Z. will review this ticket; i set it to resolved now

Comment by Christopher Zimmermann [ 04/Sep/13 ]

Review:

  • Remove config node from ui-framework if it is empty. Currently when i update from 5.0.x, the config node is left there.
  • OrderNodeTo1stPosTask
  • Remove author and version from javadoc.
  • Set Copyright to 2013.
  • OrderNodeTo1stPosTaskTest
  • Remove author from javadoc.
  • Set Copyright to 2013
  • AdmincentralModuleVersionHanderTest
  • remove commented out lines concerning "appLauncherLayoutConfigNodeSourceParent"
  • remove unused applauncherLayoutConfig
  • SecurityModuleVersionHandlerTest
  • rename testTo51EnsureSecurityAppLauncherConfigOrderAfterExtraInstallTask to
  • SecurityModuleVersionHandlerTest - remove nodeConf and nodesec from testTo51EnsureSecurityAppLauncherConfigOrderAfterExtraInstallTask

Create tickets in all affected projects and link them to this ticket.

Comment by Christoph Meier [ 09/Sep/13 ]

reopened to fix the minor issues coming from review

Comment by Christoph Meier [ 09/Sep/13 ]

fixed the minor changes according to the review

Comment by Eric Hechinger [ 10/Sep/13 ]

Could you please check your test. Work fin locally but fail on Hudson. In addition could you please simplify this test.

Comment by Christoph Meier [ 10/Sep/13 ]

simplified SecurityModuleVersionHandlerTest#testTo51EnsureSecurityAppLauncherConfigOrderAfterExtraInstallTask

Comment by Antti Hietala [ 27/Sep/13 ]

Documented in http://documentation.magnolia-cms.com/display/DOCS/App+launcher+layout

Generated at Mon Feb 12 08:51:20 CET 2024 using Jira 9.4.2#940002-sha1:46d1a51de284217efdcb32434eab47a99af2938b.