[MGNLUI-1922] Item gets renamed when saved Created: 14/Aug/13  Updated: 17/Sep/13  Resolved: 06/Sep/13

Status: Closed
Project: Magnolia UI
Component/s: None
Affects Version/s: 5.0.1
Fix Version/s: 5.1

Type: Bug Priority: Neutral
Reporter: Christian Hamm Assignee: Christoph Meier
Resolution: Fixed Votes: 1
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified
Environment:

Mac OS X ML, Tomcat, Java 6


Attachments: PNG File Screen Shot 2013-08-14 at 09.52.12.png     PNG File Screen Shot 2013-08-14 at 09.52.22.png    
Template:
Acceptance criteria:
Empty
Task DoD:
[ ]* Doc/release notes changes? Comment present?
[ ]* Downstream builds green?
[ ]* Solution information and context easily available?
[ ]* Tests
[ ]* FixVersion filled and not yet released
[ ]  Architecture Decision Record (ADR)
Bug DoR:
[ ]* Steps to reproduce, expected, and actual results filled
[ ]* Affected version filled
Date of First Response:
Sprint: 5.1 Beta1- Frontend, 5.1 - RC1

 Description   

When saving an item in a simple app that has the same name as an existing item a '0' (zero) will be appended. Editing and re-saving this particular item will have it's name changed and instead of a '0' there will be a '1'. Re-saving it again will result in being changed back to '0'.

The correct behavior should be to not change the objects name.

(I'll use contacts-app as an example in the screenshots but it applies for all other apps)



 Comments   
Comment by Christoph Meier [ 22/Aug/13 ]

The described issue

  • happens in the contacts-app
  • doesn't happen in the DAM-App an in the Pages-App (tried it out for pages ... will try it out for deeper nodes, too).

This is definitely a bug specifically in the contacs-app (at least the code which is reponsible for that issue is within the "magnolia-contacts"-module)

Comment by Christoph Meier [ 23/Aug/13 ]

I've seen that the contacts-app is setting the node-name every time (using the properties firstname, lastname to create the nodename). Since no other app does change node-names while an update, we decided not to change the nodename.

Comment by Christian Hamm [ 23/Aug/13 ]

I encountered this problem when creating a very basic content app and could reproduce this on the contacts app.

Also I looked a bit into the default info.magnolia.ui.form.action.SaveFormAction class and info.magnolia.contacts.app.form.action.SaveContactFormAction.

In both classes the name generation is ultimately done by Path.getUniqueLabel() which appears to check if an item is there and then increases or decreases the number which gets appended.

Comment by Christoph Meier [ 06/Sep/13 ]

maybe not finished ... sorry

Comment by Christoph Meier [ 06/Sep/13 ]

finally done

Generated at Mon Feb 12 08:51:27 CET 2024 using Jira 9.4.2#940002-sha1:46d1a51de284217efdcb32434eab47a99af2938b.