[MGNLUI-1925] EmbeddedPageSubApp should be able to take the url from the location as well Created: 16/Aug/13 Updated: 20/Aug/13 Resolved: 20/Aug/13 |
|
| Status: | Closed |
| Project: | Magnolia UI |
| Component/s: | None |
| Affects Version/s: | 5.0.2 |
| Fix Version/s: | 5.0.3, 5.1 |
| Type: | Improvement | Priority: | Neutral |
| Reporter: | Espen Jervidalo | Assignee: | Espen Jervidalo |
| Resolution: | Fixed | Votes: | 0 |
| Labels: | None | ||
| Remaining Estimate: | Not Specified | ||
| Time Spent: | Not Specified | ||
| Original Estimate: | Not Specified | ||
| Template: |
|
| Acceptance criteria: |
Empty
|
| Task DoD: |
[ ]*
Doc/release notes changes? Comment present?
[ ]*
Downstream builds green?
[ ]*
Solution information and context easily available?
[ ]*
Tests
[ ]*
FixVersion filled and not yet released
[ ] 
Architecture Decision Record (ADR)
|
| Date of First Response: |
| Comments |
| Comment by Federico Grilli [ 19/Aug/13 ] |
|
In EmbeddedPageSubApp.java could you pls use StringUtils.isNotBlank() from apache commons which we normally our codebase instead of com.google.common.base.Strings. |
| Comment by Espen Jervidalo [ 19/Aug/13 ] |
|
merged to master |
| Comment by Federico Grilli [ 19/Aug/13 ] |
|
Sorry didn't notice the double if condition at EmbeddedPageSubApp if (isInternalPage) { if(isInternalPage) { ... } |