[MGNLUI-195] implement JcrPropertyAdapter updating logic Created: 22/Nov/12  Updated: 11/Feb/13  Resolved: 27/Nov/12

Status: Closed
Project: Magnolia UI
Component/s: None
Affects Version/s: None
Fix Version/s: 5.0

Type: Bug Priority: Major
Reporter: Mikaël Geljić Assignee: Mikaël Geljić
Resolution: Fixed Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Issue Links:
causality
is causing MGNLUI-305 Applied input form CodeReview to JcrP... Closed
Template:
Acceptance criteria:
Empty
Task DoD:
[ ]* Doc/release notes changes? Comment present?
[ ]* Downstream builds green?
[ ]* Solution information and context easily available?
[ ]* Tests
[ ]* FixVersion filled and not yet released
[ ]  Architecture Decision Record (ADR)
Bug DoR:
[ ]* Steps to reproduce, expected, and actual results filled
[ ]* Affected version filled

 Description   

JcrPropertyAdapter was never used prior to inplace editing, so as in MGNLUI-164 for reading vaadin Properties out of a JcrPropertyAdapter, we need to be able to update the JcrPropertyAdapter back with edited values from these vaadin Properties.

First difference to NodeAdapters is that they listen to valueChanges from the DefaultProperties they generate. PropertyAdapters should do as well.

Then the JcrItem within a PropertyAdapter is currently the parent Node, which is wrong. It means we cannot get the JCR Property from the repository after init, using the getJcrItem() method from the AbstractJcrAdapter interface.

One thing to note is that some refactoring may be necessary to mutualize more code between NodeAdapters and PropertyAdapters and review the levels of abstraction, which are not clear right now. But this is out of scope for the present task.


Generated at Mon Feb 12 08:34:31 CET 2024 using Jira 9.4.2#940002-sha1:46d1a51de284217efdcb32434eab47a99af2938b.