[MGNLUI-1991] Cleanup Actionbar dependencies and apply proper MVP pattern Created: 28/Aug/13  Updated: 15/Oct/15  Resolved: 04/Apr/14

Status: Closed
Project: Magnolia UI
Component/s: actionbar
Affects Version/s: 5.1
Fix Version/s: 5.3

Type: Task Priority: Neutral
Reporter: Mikaël Geljić Assignee: Mikaël Geljić
Resolution: Fixed Votes: 0
Labels: tech-debt
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Issue Links:
causality
is causing MGNLUI-3626 Deprecate hack for multiple selection... Closed
supersession
is superseded by MGNLUI-1896 Cleanup ui-widgetset dependencies Closed
Template:
Acceptance criteria:
Empty
Task DoR:
Empty
Epic Link: Widgetset

 Description   

The Actionbar widget currently implements the View interface (ui-api) instead of having the ActionbarPresenter produce a ViewImpl that uses the Widget internally. There are also further issues that do not fall inline with the MVP pattern.

  • The widget should be ui-api agnostic.
  • The ActionbarPresenter should inject the ActionbarView
    • remove direct instantiations of the ActionbarPresenter along the way
  • The ActionbarFactory (produces a widget based on config) should be inlined inside the ActionbarPresenter.
  • The ActionbarPresenter.Listener interface shouldn't be used to get action label and icon, instead the map of ActionDefinitions should be passed into the presenter upon startup.


 Comments   
Comment by Mikaël Geljić [ 02/Sep/13 ]

Decided to attach this as a subtask of the MGNLUI-1892 widgetset configurability story for 5.1:

  • because it's closely related to the concept (see Dependencies section)
  • because it doesn't affect the action bar's behavior in any respect
  • because it's already done

The sooner we review it and merge it in, the bigger the chance to spot any potential issue.

Comment by Mikaël Geljić [ 17/Sep/13 ]

Was never integrated so far, not to increase merge hell for the i18n branch. Change needs to be readapated accordingly, and will no land in 5.1.

Generated at Mon Feb 12 08:52:08 CET 2024 using Jira 9.4.2#940002-sha1:46d1a51de284217efdcb32434eab47a99af2938b.