[MGNLUI-2109] I18n keys for forms defined in configuration are overridden by generated keys Created: 16/Sep/13 Updated: 11/Oct/13 Resolved: 16/Sep/13 |
|
| Status: | Closed |
| Project: | Magnolia UI |
| Component/s: | None |
| Affects Version/s: | None |
| Fix Version/s: | 5.1 |
| Type: | Bug | Priority: | Critical |
| Reporter: | Federico Grilli | Assignee: | Federico Grilli |
| Resolution: | Fixed | Votes: | 0 |
| Labels: | None | ||
| Remaining Estimate: | Not Specified | ||
| Time Spent: | Not Specified | ||
| Original Estimate: | Not Specified | ||
| Issue Links: |
|
||||||||||||||||||||||||||||
| Template: |
|
||||||||||||||||||||||||||||
| Acceptance criteria: |
Empty
|
||||||||||||||||||||||||||||
| Task DoD: |
[ ]*
Doc/release notes changes? Comment present?
[ ]*
Downstream builds green?
[ ]*
Solution information and context easily available?
[ ]*
Tests
[ ]*
FixVersion filled and not yet released
[ ] 
Architecture Decision Record (ADR)
|
||||||||||||||||||||||||||||
| Bug DoR: |
[ ]*
Steps to reproduce, expected, and actual results filled
[ ]*
Affected version filled
|
||||||||||||||||||||||||||||
| Sprint: | 5.1 - RC1 | ||||||||||||||||||||||||||||
| Description |
|
It should be the other way round, that is an i18n key defined in configuration takes precedence over anything else. The issue here happens in info.magnolia.ui.dialog.formdialog.FormDialogPresenterImpl.buildView(FormDialogDefinition) where the FormDialogDefinition is decorated for i18n thus generating keys which might be possibly non existant and set, without any check for their validity, as label and or description of the dialog containing the form. |