[MGNLUI-2111] LinkFieldDefinition ignores the targetTreeRootPath property Created: 16/Sep/13 Updated: 02/Oct/14 Resolved: 22/May/14 |
|
| Status: | Closed |
| Project: | Magnolia UI |
| Component/s: | forms |
| Affects Version/s: | 5.1 |
| Fix Version/s: | 5.2.5 |
| Type: | Bug | Priority: | Critical |
| Reporter: | Antti Hietala | Assignee: | Milan Divilek |
| Resolution: | Fixed | Votes: | 3 |
| Labels: | support | ||
| Remaining Estimate: | Not Specified | ||
| Time Spent: | Not Specified | ||
| Original Estimate: | Not Specified | ||
| Issue Links: |
|
||||||||||||||||||||
| Template: |
|
||||||||||||||||||||
| Acceptance criteria: |
Empty
|
||||||||||||||||||||
| Task DoD: |
[ ]*
Doc/release notes changes? Comment present?
[ ]*
Downstream builds green?
[ ]*
Solution information and context easily available?
[ ]*
Tests
[ ]*
FixVersion filled and not yet released
[ ] 
Architecture Decision Record (ADR)
|
||||||||||||||||||||
| Bug DoR: |
[ ]*
Steps to reproduce, expected, and actual results filled
[ ]*
Affected version filled
|
||||||||||||||||||||
| Release notes required: |
Yes
|
||||||||||||||||||||
| Date of First Response: | |||||||||||||||||||||
| Description |
|
LinkFieldDefinition is using appName for launching specified app used for selection. However that app is then ignoring all other properties which is especially nasty in case of targetWorkspace and targetTreeRootPath. As workaround you can create a separate app and configure it the way you want this view to behave, then reference it in appName. |
| Comments |
| Comment by Daniel Lipp [ 07/May/14 ] |
|
| Comment by Mikaël Geljić [ 13/May/14 ] |
|
| Comment by Frank Sommer [ 13/May/14 ] |
|
Here some thoughts of me about this topic:
|
| Comment by Mikaël Geljić [ 13/May/14 ] |
|
Hi Frank, We know that we definitely have to reconsider and simplify this, put the pieces where they belong as soon as possible, but that cannot be a maintenance step. Hence the conclusions from my previous comment. We do want to fix Side note, I also thought targetWorkspace could simply be deprecated, it definitely sounds obsolete in this place. |
| Comment by Mikaël Geljić [ 20/May/14 ] |
|
remaining type-mapping to deleted class info.magnolia.ui.contentapp.choosedialog.ContentAppChooseDialogPresenter in ui-contentapp.xml in 5.3 |
| Comment by Christopher Zimmermann [ 20/May/14 ] |
|
Update obsolete type mapping in ui-contentapp module descriptor. <type-mapping> |
| Comment by Aleksandr Pchelintcev [ 21/May/14 ] |
|
Re-opening because: The first line makes sure there's a field set for choose dialog definition. However, it doesn't set it directly to the definition provided as an arg, but rather clones it and returns the clone. As a result - the call ensureChooseDialogField is not applied and the definition ends up with no field. One should either assign the chooseDialogDefinition with a result of the ensureChooseDialogField call, or investigate if cloning the definition still makes sense and maybe skip it. |
| Comment by Milan Divilek [ 21/May/14 ] |
|
Wrong workbench is resolved for "Choose dialog". Clean installation of 5.2.5 EE bundle
|
| Comment by Jaroslav Simak [ 21/May/14 ] |
|
IMHO it behaves as described in documentation (look at default value of targetTreeRootPath property). But i'll check tmr with Mika to be 100% sure. |
| Comment by Milan Divilek [ 22/May/14 ] |
|
Documentation also says that we support targetWorkspace property (default value is website), but workspace is used from "Choose dialog" workbench. If targetTreeRootPath is not defined in link then we should use root path from "Choose dialog" workbench. |
| Comment by Mikaël Geljić [ 22/May/14 ] |
|
There is indeed an issue, targetTreeRootPath is always "/" it seems, if not defined, so since it is "set", it will override the default from the ChooseDialogDefinition. By the way, another one: we should not call #setPath() (or set anything) on the actual singleton definition, but rather move that to the #ensureChooseDialogField() method, so that we set the path on the cloned def. This would definitely cause concurrency problems if we have multiple link fields with different targetTreeRootPath and/or different users opening choose dialogs at the same time. |