[MGNLUI-2168] MoveInsidePossibilityPredicate sometimes allows wrong operations. Created: 27/Sep/13  Updated: 10/Sep/14  Resolved: 09/Sep/14

Status: Closed
Project: Magnolia UI
Component/s: content app
Affects Version/s: None
Fix Version/s: 5.1

Type: Bug Priority: Major
Reporter: Eric Hechinger Assignee: Aleksandr Pchelintcev
Resolution: Fixed Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Issue Links:
relation
is related to MAGNOLIA-4955 It should not be possible to move a p... Closed
supersession
is superseded by MGNLUI-3146 Make pages move functionality (both v... Closed
Template:
Acceptance criteria:
Empty
Task DoD:
[ ]* Doc/release notes changes? Comment present?
[ ]* Downstream builds green?
[ ]* Solution information and context easily available?
[ ]* Tests
[ ]* FixVersion filled and not yet released
[ ]  Architecture Decision Record (ADR)
Bug DoR:
[ ]* Steps to reproduce, expected, and actual results filled
[ ]* Affected version filled
Date of First Response:
Sprint: 5.1 - Final

 Description   

Currently Move Action is too permissive... For example in page app it is possible to move pages under other pages without any check.
These check are done in TemplateTypeRestrictionDropConstraint for pages app.

MoveDialogPresenter uses that constraint, but the predicate that validates possibility of moving item inside the selected one sometimes grants permission before the constraint is used. It assumes that the destination node is root because the getParent() call for JcrNodeAdapter returns null (see MGNLUI-2169).



 Comments   
Comment by Eric Hechinger [ 27/Sep/13 ]

take for example
/demo-project/about/subsection-articles/article
this may be moved into
/demo-project/news-and-events/events-overview but
not under
/demo-project/news-and-events

Unfortunately, the move dialog allows to do it.

Comment by Antti Hietala [ 08/Sep/14 ]

Reopened. Check also the Move before and Move after actions. They allow an editor to move a page to a location where creating the page would not be allowed.

Generated at Mon Feb 12 08:53:52 CET 2024 using Jira 9.4.2#940002-sha1:46d1a51de284217efdcb32434eab47a99af2938b.