[MGNLUI-2195] i18n - Forms and dialogs are not properly decorated Created: 01/Oct/13  Updated: 09/Mar/21  Resolved: 09/Mar/21

Status: Closed
Project: Magnolia UI
Component/s: None
Affects Version/s: 5.1
Fix Version/s: None

Type: Bug Priority: Critical
Reporter: Federico Grilli Assignee: Federico Grilli
Resolution: Obsolete Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Issue Links:
Cloners
clones MGNLUI-2135 Forms and dialogs are not properly de... Closed
relation
is related to MGNLUI-2196 Revisit Dialog API and related concepts Closed
is related to MAGNOLIA-5332 AbstractI18nKeyGenerator could expose... Closed
Template:
Acceptance criteria:
Empty
Task DoD:
[ ]* Doc/release notes changes? Comment present?
[ ]* Downstream builds green?
[ ]* Solution information and context easily available?
[ ]* Tests
[ ]* FixVersion filled and not yet released
[ ]  Architecture Decision Record (ADR)
Bug DoR:
[ ]* Steps to reproduce, expected, and actual results filled
[ ]* Affected version filled

 Description   

Fixes for MGNLUI-2135 are unsatisfactory.

One of the reasons is that some presenters pass an already-decorated definition to info.magnolia.ui.dialog.BaseDialogPresenter#start, and some don't. After an initial analysis with [@pbaerfuss], we thought we'd move that responsibility to the caller. After further investigation:

  • There are "too many" places where this should occur, and that would somewhat hide/obscure the calls to I18nizer.
  • DialogPresenter#start does not make sense as an interface method. Every presenter reimplements a start() method with their specific argument (see sub-interfaces), so it is never a real entry point.

BaseDialogPresenter#getI18nizer should not be there.
The definition passed to info.magnolia.ui.dialog.BaseDialogPresenter#start should be already decorated. (tried to get to that but failed for 5.1)


Generated at Mon Feb 12 08:54:08 CET 2024 using Jira 9.4.2#940002-sha1:46d1a51de284217efdcb32434eab47a99af2938b.