i18n: use new i18n for all text in Magnolia - Master Ticket (MGNLUI-2131)

[MGNLUI-2210] i18n fixes: Improvements to ContentApp, BaseDialogPresenter, AbstractDeleteGroupOrRoleAction Created: 02/Oct/13  Updated: 03/Oct/13  Resolved: 03/Oct/13

Status: Closed
Project: Magnolia UI
Component/s: None
Affects Version/s: 5.1
Fix Version/s: 5.1

Type: Sub-task Priority: Neutral
Reporter: Christopher Zimmermann Assignee: Christopher Zimmermann
Resolution: Fixed Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Template:
Sprint: 5.1 - Final

 Description   

From review document:

Detail Editor
CLZ
info.magnolia.ui.contentapp.detail.DetailEditorPresenter#CONTENTAPP_BASENAME should go away (not used, not needed)

DetailEditorPresenter message formatting in catch blocks
info.magnolia.ui.contentapp.detail.DetailPresenter#i18nizer - injected deps should be final
but is actually not used in this specific case

info.magnolia.ui.contentapp.detail.DetailSubApp#setCaption uses a pages-app key, but isn't specific to pages app

BaseDialogPresenter: #decorateForI18n
//TODO Christopher Zimmermann - Verify that this is still necessary.
--> it is not. (CLZ says - I think the tests are OK.)
It's only used in tests (Which are probably broken, since they test sthg that isn't used)

Improve calls to SimpleTranslator
info.magnolia.security.app.action.AbstractDeleteGroupOrRoleAction
#getI18n probably not relevant
CLZ
security.delete.group.or.role.group this key is really poorly named. (security.delete.group ?)
#getUsersAndGroupsThisItemIsAssignedTo does some suspicious concatenation, should use formatting, and the 2 keys are probably completeley redundant (use formatting too)


Generated at Mon Feb 12 08:54:16 CET 2024 using Jira 9.4.2#940002-sha1:46d1a51de284217efdcb32434eab47a99af2938b.