i18n: use new i18n for all text in Magnolia - Master Ticket (MGNLUI-2131)

[MGNLUI-2221] i18n fixes: AppInstanceControllerImpl and SecurityApp Created: 03/Oct/13  Updated: 03/Oct/13  Resolved: 03/Oct/13

Status: Closed
Project: Magnolia UI
Component/s: None
Affects Version/s: 5.1
Fix Version/s: 5.1

Type: Sub-task Priority: Neutral
Reporter: Christopher Zimmermann Assignee: Christopher Zimmermann
Resolution: Fixed Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Template:
Date of First Response:
Sprint: 5.1 - Final

 Description   

https://docs.google.com/document/d/1FTEG7kQcIYhRcuOhsiN3lY2D1P83cdXH9RVtpCS5u8U/edit#

info.magnolia.ui.framework.app.AppInstanceControllerImpl#start (5.1)
Message subject is supposed to be formatted but really isn't
"ui-framework.app.appinstance.memory-limit-warning.message" is not translated anywhere

info.magnolia.monitoring.SystemMonitor#MEMORY_LIMIT_IS_REACHED_STRING_FORMAT
should be a key
info.magnolia.security.app.dialog.field.WorkspaceAccessFieldFactory (5.1)
didn't have @Inject, why does it need it now ?
#componentProvider - unused

info.magnolia.security.app.dialog.action.SaveUserDialogAction#i18n should be private !
is only used to translate an exception that should probably never occur anyway ? (i.e ActionAvailability should prevent it from being available on root)
5.1 If the above assumption is correct (AA prevents this from happening in normal situations), remove i18n from this completely, no need to trasnalte systen exceptions)



 Comments   
Comment by Christoph Meier [ 03/Oct/13 ]

Review:
AppInstanceControllerImpl#start can be simplified.
There is no need for 2 key-value-pairs, one should be suficient.

Comment by Christoph Meier [ 03/Oct/13 ]

Review:
AppInstanceControllerImpl#start can be simplified.
There is no need for 2 key-value-pairs, one should be suficient.

Comment by Christopher Zimmermann [ 03/Oct/13 ]

There is a need for 2 key-value-pairs - in case others want to insert another reason in there.

Generated at Mon Feb 12 08:54:22 CET 2024 using Jira 9.4.2#940002-sha1:46d1a51de284217efdcb32434eab47a99af2938b.