[MGNLUI-2231] Publishing the deletion of a page leads to a page in a weird state Created: 03/Oct/13  Updated: 10/Dec/13  Resolved: 09/Dec/13

Status: Closed
Project: Magnolia UI
Component/s: pages app
Affects Version/s: 5.1, 5.2
Fix Version/s: 5.2.1

Type: Bug Priority: Critical
Reporter: Andreas Weder Assignee: Mikaël Geljić
Resolution: Fixed Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified
Environment:

5.1 Enterprise Edition
5.2 beta 1 Enterprise Edition


Attachments: PNG File Reproduce 1.png     PNG File Reproduce 2.png     PNG File Reproduce 3-1.png     PNG File Reproduce 3-2.png     PNG File Reproduce 4-2.png     PNG File Reproduce 5.png     PNG File deleted-page-in-tree-view.png    
Issue Links:
relation
is related to MGNLUI-2445 Internal Error and nodes in weird sta... Closed
Template:
Acceptance criteria:
Empty
Task DoD:
[ ]* Doc/release notes changes? Comment present?
[ ]* Downstream builds green?
[ ]* Solution information and context easily available?
[ ]* Tests
[ ]* FixVersion filled and not yet released
[ ]  Architecture Decision Record (ADR)
Bug DoR:
[ ]* Steps to reproduce, expected, and actual results filled
[ ]* Affected version filled
Date of First Response:
Sprint: 5.2.1

 Description   

When I attempt to publish the deletion of a page, I get a weird top-level page with no icon until I close and re-open the Pages app.

Steps to reproduce:
(I've done this as "superuser")

  1. Select the "interesting article" page in the demo project (see Reproduce 1.png). Click on "delete page".
  2. The page is being marked as deleted and a publication request is issued (see Reproduce 2.png).
  3. Open the Pulse message that announces the deletion request, then approve it. You get a confirmation notification (see Reproduce 3-1.png and Reproduce 3-2.png).
  4. In Pages app, the page still looks as before, but if you reload, you see that the page has actually moved to the top level and is missing its icon (see Reproduce 5.png). Selecting it leads to an action bar offering only the "add page" action.

Also reproducible when having configuration app open on public and deleting a visible node on author. It even crashes the the whole admincentral. by Internal Error.



 Comments   
Comment by Christoph Meier [ 09/Oct/13 ]

in a 1st attempt i'm not able to reproduce the above described issue. Instead everything worked as expected.
(I tried with ee-bundle; started as manual integration test; as superuser)

Comment by Andreas Weder [ 09/Oct/13 ]

I've been able to reproduce this error with 5.1 final, but with a slightly different result:

  • there's no exception any more
  • I still see the weird top-level page without an icon after publishing the deletion.
    • When I delete a second page, that page gets to the top-level with no icon as well, but the first one disappears entirely.
    • When I close and re-open Pages, all weird top-level pages have disappeared.
Comment by Andreas Weder [ 09/Oct/13 ]

I've updated this issue to reflect the current state with 5.1 EE final. I've also lowered the priority, since I get no exception any more and there's a workaround (close and re-open Pages).

Comment by Christoph Meier [ 09/Oct/13 ]

so. for me this looks more like a bug in the tree-view ... maybe.

Comment by Christoph Meier [ 15/Oct/13 ]

i have the impression, that the described behavior is due to an error in updating the views.
in both tree- and list-view the deleted page remains (mostly).
when clicking around (selecting another item, changing the view-type), the position of the page in the view changes (see attachment deleted-page-in-tree-view.png), and also the path changes (see Reproduce 5.png), whereat the change of the path in many cases occurs after the change of the visible location (weird).
At the latest when closing and reopening the Pages-app, the views look correct and the deleted page has gone.
The status of the colored icon also lags behind the "real" status, e.g. when publishing a page.

According to Sasha, this could be fixed by forcibly re-querying the container on app-restore, but he believes that is not scheduled for nearest future ... hm ...

Comment by Andreas Weder [ 13/Nov/13 ]

This problem still exists in 5.2 beta 1 and shows up the same as in 5.1 final, so:

  • there's no exception
  • I still see the weird top-level page without an icon after publishing the deletion.
    • When I delete a second page, that page gets to the top-level with no icon as well, but the first one disappears entirely.
    • When I close and re-open Pages, all weird top-level pages have disappeared.
Comment by Daniel Lipp [ 13/Nov/13 ]

This bug is not showing up in ce-edition: must be that container is not properly refreshed in ee where the publication is not immediately happening but only after approval…
Biggest issue is probably that the item is moved to the root level - that fact that it's not gone is kind of known as the same thing is happening in other situations as well (because of a lack of appropriate events for containers).

Comment by Espen Jervidalo [ 21/Nov/13 ]

for the second use case, here's a snippet from the log:

2013-11-21 10:39:07,290 INFO info.magnolia.module.activation.ReceiveFilter : User superuser succeessfuly deactivated /modules/core/testt on magnoliaPublic.
2013-11-21 10:39:07,339 INFO info.magnolia.ui.workbench.WorkbenchPresenter : Trying to re-sync workbench with no longer existing path 05d001dd-21e0-42a8-ac1c-36a26bd2d960 at workspace config. Will reset path to its configured root /.
2013-11-21 10:39:11,628 WARN gnolia.ui.workbench.container.AbstractJcrContainer: Couldn't find item 05d001dd-21e0-42a8-ac1c-36a26bd2d960 so property jcrName can't be retrieved!
2013-11-21 10:39:11,628 WARN gnolia.ui.workbench.container.AbstractJcrContainer: Couldn't find item 05d001dd-21e0-42a8-ac1c-36a26bd2d960 so property value can't be retrieved!
2013-11-21 10:39:11,628 WARN gnolia.ui.workbench.container.AbstractJcrContainer: Couldn't find item 05d001dd-21e0-42a8-ac1c-36a26bd2d960 so property type can't be retrieved!
2013-11-21 10:39:11,628 WARN gnolia.ui.workbench.container.AbstractJcrContainer: Couldn't find item 05d001dd-21e0-42a8-ac1c-36a26bd2d960 so property mgnl:lastModified can't be retrieved!
Nov 21, 2013 10:41:42 AM com.vaadin.server.communication.ServerRpcHandler parseInvocation
WARNING: RPC call to info.magnolia.ui.vaadin.gwt.client.dialog.rpc.OverlayServerRpc.onClosed received for connector 137 but no such connector could be found. Resynchronizing client.

Generated at Mon Feb 12 08:54:28 CET 2024 using Jira 9.4.2#940002-sha1:46d1a51de284217efdcb32434eab47a99af2938b.