[MGNLUI-2258] Enable i18n for SelectField options Created: 09/Oct/13  Updated: 09/Oct/13  Resolved: 09/Oct/13

Status: Closed
Project: Magnolia UI
Component/s: None
Affects Version/s: 5.1
Fix Version/s: 5.1.1

Type: Improvement Priority: Neutral
Reporter: Espen Jervidalo Assignee: Espen Jervidalo
Resolution: Fixed Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Template:
Acceptance criteria:
Empty
Task DoD:
[ ]* Doc/release notes changes? Comment present?
[ ]* Downstream builds green?
[ ]* Solution information and context easily available?
[ ]* Tests
[ ]* FixVersion filled and not yet released
[ ]  Architecture Decision Record (ADR)
Date of First Response:

 Description   

Currently Select field options are not using i18n. There is no key generator and the label is not i18nized.



 Comments   
Comment by Magnolia International [ 09/Oct/13 ]

Your log message in catch (NoSuchMethodException e) is not accurate. If you're doing SelectFieldDefinition.class.getMethod, then you know you have a SelectFieldDefinition. That said, not sure why you do

 FieldDefinition selectField = getParentViaCast(definition);

and not

 SelectFieldDefinition selectField = getParentViaCast(definition);

?

Comment by Espen Jervidalo [ 09/Oct/13 ]

The reason is explained in the classes javadoc.
It's used by SwitchabelFieldDef and SelectFielDef. which do neot extend or implement anything common except FieldDefinition.

Generated at Mon Feb 12 08:54:44 CET 2024 using Jira 9.4.2#940002-sha1:46d1a51de284217efdcb32434eab47a99af2938b.