[MGNLUI-2266] Allow text area field relying on the AceEditor for editing to go "full dialog" Created: 10/Oct/13  Updated: 05/Dec/14  Resolved: 08/Oct/14

Status: Closed
Project: Magnolia UI
Component/s: dialogs, forms
Affects Version/s: 5.1
Fix Version/s: 5.3.5

Type: Improvement Priority: Major
Reporter: Andreas Weder Assignee: Aleksandr Pchelintcev
Resolution: Fixed Votes: 2
Labels: maintenance, support, usability, ux
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Attachments: PNG File Conversation.png     PNG File inplace-templating-ui-issues.png    
Issue Links:
relation
is related to MGNLUI-2267 Dialog can be toggled "wide" with but... Closed
is related to MGNLUI-2996 As a user, I can toggle dialogs and s... Closed
is related to MGNLUI-3229 CKEditor stretcher disappears in sour... Closed
Template:
Acceptance criteria:
Empty
Task DoD:
[ ]* Doc/release notes changes? Comment present?
[ ]* Downstream builds green?
[ ]* Solution information and context easily available?
[ ]* Tests
[ ]* FixVersion filled and not yet released
[ ]  Architecture Decision Record (ADR)
Date of First Response:

 Description   

We offer a toggle to make text areas and rich text areas go full-dialog: they take up the entire space available to the dialog except the for the header.

For fields such as the BasicTextCodeField in the in-place editing module (see attached screenshot), which use the Vaadin AceEditor plug-in, such a toggle does not exist yet.

Please research what would be needed to fix this first and whether this is feasible to be done during extended maintenance.



 Comments   
Comment by Andreas Weder [ 10/Oct/13 ]

Added a conversation about this we had in Hipchat, as a screen shot.

Comment by Jan Haderka [ 28/Jan/14 ]

The longer you have to work with templates, resources or scripts loaded on a live system the more annoying it gets. Specially since as a developer you need to be able to see biggest possible chunk of the script on a page to be able to spot bugs in it or to work with loops or other more complex code structures.

Comment by Tomáš Gregovský [ 28/Jan/14 ]

any progress? editing templates or resources in this really small text area is little bit complicated, other textareas with CKeditor has small arrows in corner to enlarge and have same in AceEditor will be much better.

But there is still question why whole dialog is just 720px wide on big screens and around is so much gray empty area... same arrows in dialog corner which will resize whole dialog to fullscreen will be absolutely best solution.

Comment by Andreas Weder [ 28/Jan/14 ]

Yes, the idea still is that rich text area fields using the Ace Editor should behave just like any other text areas and offer the mentioned control to take them full-dialog. I'm scheduling this to be looked at as one of possible maintenance topics.

As for dialog widths, we plan to tackle this as UI polishing work for the 5.3 release. Here's the conceptual idea behind the change: http://jira.magnolia-cms.com/browse/MGNLUI-2267

Comment by Richard Unger [ 29/Jan/14 ]

+1 please implement this!

Comment by Christopher Zimmermann [ 17/Jul/14 ]

Agreed, very important. We have the "wide dialog" feature now which would be a quick fix for 5.3. And I agree it would be nice to have the button in the corner to make the editor go full dialog (i know there were some technical challenges there.)
But im writing this comment to request something different - I think ideally the field should be wide (as mentioned above, but also tall - expanding with the browser as the browser expands. We all know that an editor would want the field as big as possible - ideally they would not have to click a button to do that.
I think this could be a hard request to fulfill - and that it might have to be done with a non-standard dialog which expands itself based on a knowledge of the height of the checkboxes.
I write this because I think the ultimate vision is that the inplace templating would be as close to an ide as possible.

Generated at Mon Feb 12 08:54:49 CET 2024 using Jira 9.4.2#940002-sha1:46d1a51de284217efdcb32434eab47a99af2938b.