[MGNLUI-2292] Cannot create new group/role Created: 16/Oct/13  Updated: 07/Jul/14  Resolved: 18/Oct/13

Status: Closed
Project: Magnolia UI
Component/s: security app
Affects Version/s: 5.1.1
Fix Version/s: 5.1.1

Type: Bug Priority: Blocker
Reporter: Jozef Chocholacek Assignee: Jozef Chocholacek
Resolution: Fixed Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Template:
Acceptance criteria:
Empty
Task DoD:
[ ]* Doc/release notes changes? Comment present?
[ ]* Downstream builds green?
[ ]* Solution information and context easily available?
[ ]* Tests
[ ]* FixVersion filled and not yet released
[ ]  Architecture Decision Record (ADR)
Bug DoR:
[ ]* Steps to reproduce, expected, and actual results filled
[ ]* Affected version filled
Date of First Response:
Sprint: 5.1.1

 Description   

Caused by fix for MGNLUI-2158 - the BrowserPresenter.executeAction(String actionName) does not check, whether the selected item is the workbench root, or normal item.



 Comments   
Comment by Mikaël Geljić [ 17/Oct/13 ]
  • You may use #getWorkspace() directly in BP line 387
  • Drop a comment there as per why the action executor expects null
  • in BPTest, use an assert here, not verify
Comment by Mikaël Geljić [ 18/Oct/13 ]
  • Marked as Reviewed despite the verifies in BPTest. I understand that in this particular case, we're not interested in the availability itself but in what is passed to the executor. IMO this highlights a design flaw. I'd rather have a (maybe optional) isRootNode boolean parameter to pass to the executor rather than artificially passing null and having to guarantee that. By improving the API we can guide the usages more naturally into the right direction.
Generated at Mon Feb 12 08:55:06 CET 2024 using Jira 9.4.2#940002-sha1:46d1a51de284217efdcb32434eab47a99af2938b.