[MGNLUI-2318] Ace editor fieldBuilder should support height like textarea Created: 24/Oct/13  Updated: 02/Jun/15  Resolved: 20/May/15

Status: Closed
Project: Magnolia UI
Component/s: forms
Affects Version/s: 5.3
Fix Version/s: 5.4

Type: Improvement Priority: Neutral
Reporter: Federico Grilli Assignee: Mikaël Geljić
Resolution: Fixed Votes: 0
Labels: ace, resources-app
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Template:
Acceptance criteria:
Empty
Task DoD:
[ ]* Doc/release notes changes? Comment present?
[ ]* Downstream builds green?
[ ]* Solution information and context easily available?
[ ]* Tests
[ ]* FixVersion filled and not yet released
[ ]  Architecture Decision Record (ADR)
Date of First Response:

 Comments   
Comment by Mikaël Geljić [ 18/May/15 ]

Done literally in 5 minutes while working on the new resources app Maybe the definition also deserves a relevant default value; in the Vaadin add-on, AceEditor's height is set to 200px by default, which hardly makes sense for the use cases we have imo.
(proposing 300px to accomodate with other potential fields)

Side note: ideally we also need more freedom with form dialog layout, e.g. using full available height.
The current trade-off is: if available height is too low and text content long enough, then we have a chance to see double scrollbars.

Generated at Mon Feb 12 08:55:24 CET 2024 using Jira 9.4.2#940002-sha1:46d1a51de284217efdcb32434eab47a99af2938b.