[MGNLUI-2329] i18n: some app labels & icons are still hardcoded in configuration Created: 28/Oct/13 Updated: 18/Nov/13 Resolved: 12/Nov/13 |
|
| Status: | Closed |
| Project: | Magnolia UI |
| Component/s: | None |
| Affects Version/s: | 5.1.1 |
| Fix Version/s: | 5.1.2 |
| Type: | Bug | Priority: | Critical |
| Reporter: | Christopher Zimmermann | Assignee: | Christopher Zimmermann |
| Resolution: | Fixed | Votes: | 0 |
| Labels: | None | ||
| Remaining Estimate: | Not Specified | ||
| Time Spent: | Not Specified | ||
| Original Estimate: | Not Specified | ||
| Issue Links: |
|
||||||||||||||||||||||||||||||||||||
| Template: |
|
||||||||||||||||||||||||||||||||||||
| Acceptance criteria: |
Empty
|
||||||||||||||||||||||||||||||||||||
| Task DoD: |
[ ]*
Doc/release notes changes? Comment present?
[ ]*
Downstream builds green?
[ ]*
Solution information and context easily available?
[ ]*
Tests
[ ]*
FixVersion filled and not yet released
[ ] 
Architecture Decision Record (ADR)
|
||||||||||||||||||||||||||||||||||||
| Bug DoR: |
[ ]*
Steps to reproduce, expected, and actual results filled
[ ]*
Affected version filled
|
||||||||||||||||||||||||||||||||||||
| Date of First Response: | |||||||||||||||||||||||||||||||||||||
| Sprint: | 5.1.2 | ||||||||||||||||||||||||||||||||||||
| Description |
|
For example - most of the apps in /modules/ui-admincentral/apps have a hard coded name and icon. Additionally - I notice that when the configuration of these labels is removed - the system manages to still find english labels - im not sure where it gets these. Anyways - english keys should be added to property files following the pattern of: contacts.app.label=Contacts list of apps that dont look correct in chinese:
STK: Data: Tools: Dev: |
| Comments |
| Comment by Christopher Zimmermann [ 06/Nov/13 ] |
|
Changed JcrBrowserContentAppTask to only add icon or label properties if the supplied values are not blank. (Because for i18n these should be blank) For apps: configuration, jcr browser, sample, messages: Removed icon and label properties from bootstrap files. Note - the translations actually already exist in the .properties files - they just were not being called because of the configuration (removed in this ticket). |
| Comment by Christoph Meier [ 07/Nov/13 ] |
|
Review:
|