[MGNLUI-2329] i18n: some app labels & icons are still hardcoded in configuration Created: 28/Oct/13  Updated: 18/Nov/13  Resolved: 12/Nov/13

Status: Closed
Project: Magnolia UI
Component/s: None
Affects Version/s: 5.1.1
Fix Version/s: 5.1.2

Type: Bug Priority: Critical
Reporter: Christopher Zimmermann Assignee: Christopher Zimmermann
Resolution: Fixed Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Issue Links:
Cloners
is cloned by MGNLUI-2376 CLONE - i18n: some app labels & icons... Closed
Relates
relates to MGNLUI-2330 i18n: STK and DATA app groups on the ... Closed
dependency
depends upon MGNLSTK-1270 i18n: some app labels & icons are sti... Closed
depends upon MGNLADMLEG-36 i18n: some app labels & icons are sti... Closed
depends upon MGNLCACHE-28 i18n: some app labels & icons are sti... Closed
depends upon MGNLGROOVY-89 i18n: some app labels & icons are sti... Closed
Template:
Acceptance criteria:
Empty
Task DoD:
[ ]* Doc/release notes changes? Comment present?
[ ]* Downstream builds green?
[ ]* Solution information and context easily available?
[ ]* Tests
[ ]* FixVersion filled and not yet released
[ ]  Architecture Decision Record (ADR)
Bug DoR:
[ ]* Steps to reproduce, expected, and actual results filled
[ ]* Affected version filled
Date of First Response:
Sprint: 5.1.2

 Description   

For example - most of the apps in /modules/ui-admincentral/apps have a hard coded name and icon.
These must all be removed and a version handler added.

Additionally - I notice that when the configuration of these labels is removed - the system manages to still find english labels - im not sure where it gets these.

Anyways - english keys should be added to property files following the pattern of:

contacts.app.label=Contacts
contacts.app.icon=icon-people

list of apps that dont look correct in chinese:

  • = defined in /modules/ui-admincentral/apps

STK:
Templates (inplace-templating) - no label defined - but theres an icon.
Resources (resources) - no label or icon defined.
Site Definitions *
Themes *
Dialog Definitions *
Channels *
Template Definitions *

Data:
Company *
RSS Aggregators *

Tools:
JCR *
Log Viewer *
Config info *
Export *
Import *
JCR queries *
Permissions *
Cache tools *

Dev:
Dev tools *
Messages (messages) - messages-app [ui project] - icon and label defined.
Sample (sample) - sample-app [ui project] - icon and label defined.
Groovy console *
Groovy scripts *
Mail tools (mail) - no label or icon defined.



 Comments   
Comment by Christopher Zimmermann [ 06/Nov/13 ]

Changed JcrBrowserContentAppTask to only add icon or label properties if the supplied values are not blank. (Because for i18n these should be blank)

For apps: configuration, jcr browser, sample, messages:

Removed icon and label properties from bootstrap files.
Added update tasks to remove these properties.

Note - the translations actually already exist in the .properties files - they just were not being called because of the configuration (removed in this ticket).

Comment by Christoph Meier [ 07/Nov/13 ]

Review:

  • simplify JcrBrowserContentAppTask (L.175)
    besides that, looks good for me
Generated at Mon Feb 12 08:55:31 CET 2024 using Jira 9.4.2#940002-sha1:46d1a51de284217efdcb32434eab47a99af2938b.