[MGNLUI-2333] CompositeTransformer.writeToItem fails with Static fields Created: 29/Oct/13  Updated: 14/Feb/14  Resolved: 14/Feb/14

Status: Closed
Project: Magnolia UI
Component/s: forms
Affects Version/s: 5.1.1
Fix Version/s: 5.2.2

Type: Bug Priority: Major
Reporter: Marek Swiecznik Assignee: Eric Hechinger
Resolution: Fixed Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Attachments: PNG File composite.png     XML File config.modules.samples.dialogs.samplesFieldShowRoom.form.tabs.tabInError.xml     XML File config.modules.samples.dialogs.samplesFieldShowRoom.form.tabs.tabSwitch.xml     XML File config.modules.templating.dialogs.tabComponent.xml    
Issue Links:
Relates
relates to MGNLUI-2682 Multi field defining a composite fiel... Closed
Template:
Acceptance criteria:
Empty
Task DoD:
[ ]* Doc/release notes changes? Comment present?
[ ]* Downstream builds green?
[ ]* Solution information and context easily available?
[ ]* Tests
[ ]* FixVersion filled and not yet released
[ ]  Architecture Decision Record (ADR)
Bug DoR:
[ ]* Steps to reproduce, expected, and actual results filled
[ ]* Affected version filled
Date of First Response:
Sprint: 5.2-rc2

 Description   

Having a CompositeField containing a Static field and any non-static field, e.g. TextField, after typing some text in TextField, CompositeTransformer fails in method writeToItem:
relatedFormItem.addItemProperty(compositePropertyName, newValues.getItemProperty(propertyName));

for propertyName = Static field property name, newValues.getItemProperty(propertyName) is null. CompositeField configuration in attachment.

Caused by: java.lang.NullPointerException
at info.magnolia.ui.vaadin.integration.jcr.JcrNodeAdapter.addItemProperty(JcrNodeAdapter.java:112)
at info.magnolia.ui.form.field.transformer.composite.CompositeTransformer.writeToItem(CompositeTransformer.java:86)
at info.magnolia.ui.form.field.transformer.composite.CompositeTransformer.writeToItem(CompositeTransformer.java:58)
at info.magnolia.ui.form.field.transformer.TransformedProperty.setValue(TransformedProperty.java:67)
at info.magnolia.ui.form.field.AbstractCustomMultiField$1.valueChange(AbstractCustomMultiField.java:129)

Exception generated when defining a multi value field that embedded a composite (link + static)

java.lang.NullPointerException
	at info.magnolia.ui.vaadin.integration.jcr.JcrNodeAdapter.addItemProperty(JcrNodeAdapter.java:112)
	at info.magnolia.ui.form.field.transformer.multi.MultiValueSubChildrenNodePropertiesTransformer.setChildItemValue(MultiValueSubChildrenNodePropertiesTransformer.java:137)
	at info.magnolia.ui.form.field.transformer.multi.MultiValueChildrenNodeTransformer.setNewChildItem(MultiValueChildrenNodeTransformer.java:223)
	at info.magnolia.ui.form.field.transformer.multi.MultiValueChildrenNodeTransformer.writeToItem(MultiValueChildrenNodeTransformer.java:134)
	at info.magnolia.ui.form.field.transformer.multi.MultiValueChildrenNodeTransformer.writeToItem(MultiValueChildrenNodeTransformer.java:1)
	at info.magnolia.ui.form.field.transformer.TransformedProperty.setValue(TransformedProperty.java:67)
	at info.magnolia.ui.form.field.AbstractCustomMultiField$1.valueChange(AbstractCustomMultiField.java:129)
	at sun.reflect.GeneratedMethodAccessor403.invoke(Unknown Source)
	at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25)
	at java.lang.reflect.Method.invoke(Method.java:597)
	at com.vaadin.event.ListenerMethod.receiveEvent(ListenerMethod.java:508)
	at com.vaadin.event.EventRouter.fireEvent(EventRouter.java:167)
	at com.vaadin.server.AbstractClientConnector.fireEvent(AbstractClientConnector.java:969)
	at com.vaadin.ui.AbstractField.fireValueChange(AbstractField.java:1126)
	at com.vaadin.ui.AbstractField.valueChange(AbstractField.java:1276)
	at com.vaadin.data.util.AbstractProperty.fireValueChange(AbstractProperty.java:271)
	at com.vaadin.data.util.ObjectProperty.setValue(ObjectProperty.java:140)
	at info.magnolia.ui.vaadin.integration.jcr.DefaultProperty.setValue(DefaultProperty.java:68)
	at info.magnolia.ui.form.field.AbstractCustomMultiField$1.valueChange(AbstractCustomMultiField.java:129)
	at sun.reflect.GeneratedMethodAccessor403.invoke(Unknown Source)
	at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25)
	at java.lang.reflect.Method.invoke(Method.java:597)
	at com.vaadin.event.ListenerMethod.receiveEvent(ListenerMethod.java:508)
	at com.vaadin.event.EventRouter.fireEvent(EventRouter.java:167)
	at com.vaadin.server.AbstractClientConnector.fireEvent(AbstractClientConnector.java:969)
	at com.vaadin.ui.AbstractField.fireValueChange(AbstractField.java:1126)
	at com.vaadin.ui.AbstractField.valueChange(AbstractField.java:1276)
	at com.vaadin.data.util.AbstractProperty.fireValueChange(AbstractProperty.java:271)
	at com.vaadin.data.util.ObjectProperty.setValue(ObjectProperty.java:140)
	at info.magnolia.ui.form.field.transformer.TransformedProperty.setValue(TransformedProperty.java:65)
	at com.vaadin.ui.AbstractField.setValue(AbstractField.java:508)
	at com.vaadin.ui.AbstractField.setValue(AbstractField.java:445)
	at com.vaadin.ui.AbstractTextField.setValue(AbstractTextField.java:432)
	at info.magnolia.ui.form.field.LinkField.setValue(LinkField.java:161)
	at info.magnolia.ui.form.field.LinkField$3$1.onItemChosen(LinkField.java:264)
	at info.magnolia.ui.dialog.choosedialog.action.ChooseDialogAction.execute(ChooseDialogAction.java:67)
	at info.magnolia.ui.api.action.AbstractActionExecutor.execute(AbstractActionExecutor.java:74)
	at info.magnolia.ui.dialog.BaseDialogPresenter.executeAction(BaseDialogPresenter.java:180)
	at info.magnolia.ui.dialog.BaseDialogPresenter.onActionFired(BaseDialogPresenter.java:171)
	at info.magnolia.ui.dialog.actionarea.renderer.DefaultEditorActionRenderer$1.buttonClick(DefaultEditorActionRenderer.java:56)
	at sun.reflect.GeneratedMethodAccessor488.invoke(Unknown Source)
	at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25)
	at java.lang.reflect.Method.invoke(Method.java:597)
	at com.vaadin.event.ListenerMethod.receiveEvent(ListenerMethod.java:508)
	at com.vaadin.event.EventRouter.fireEvent(EventRouter.java:167)
	at com.vaadin.server.AbstractClientConnector.fireEvent(AbstractClientConnector.java:969)
	at com.vaadin.ui.Button.fireClick(Button.java:368)
	at com.vaadin.ui.Button$1.click(Button.java:57)
	at sun.reflect.GeneratedMethodAccessor487.invoke(Unknown Source)
	at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25)
	at java.lang.reflect.Method.invoke(Method.java:597)
	at com.vaadin.server.ServerRpcManager.applyInvocation(ServerRpcManager.java:168)
	at com.vaadin.server.ServerRpcManager.applyInvocation(ServerRpcManager.java:118)
	at com.vaadin.server.communication.ServerRpcHandler.handleBurst(ServerRpcHandler.java:214)
	at com.vaadin.server.communication.ServerRpcHandler.handleRpc(ServerRpcHandler.java:111)
	at com.vaadin.server.communication.UidlRequestHandler.synchronizedHandleRequest(UidlRequestHandler.java:91)
	at com.vaadin.server.SynchronizedRequestHandler.handleRequest(SynchronizedRequestHandler.java:37)
	at com.vaadin.server.VaadinService.handleRequest(VaadinService.java:1371)
	at com.vaadin.server.VaadinServlet.service(VaadinServlet.java:238)
	at info.magnolia.ui.admincentral.AdmincentralVaadinServlet.service(AdmincentralVaadinServlet.java:131)
	at javax.servlet.http.HttpServlet.service(HttpServlet.java:728)
	at info.magnolia.cms.filters.ServletDispatchingFilter.doFilter(ServletDispatchingFilter.java:126)
	at info.magnolia.cms.filters.AbstractMgnlFilter.doFilter(AbstractMgnlFilter.java:89)
	at info.magnolia.cms.filters.MgnlFilterChain.doFilter(MgnlFilterChain.java:80)
	at info.magnolia.cms.filters.MgnlFilterChain.doFilter(MgnlFilterChain.java:82)
	at info.magnolia.cms.filters.MgnlFilterChain.doFilter(MgnlFilterChain.java:82)
	at info.magnolia.cms.filters.MgnlFilterChain.doFilter(MgnlFilterChain.java:82)
	at info.magnolia.cms.filters.MgnlFilterChain.doFilter(MgnlFilterChain.java:82)
	at info.magnolia.cms.filters.CompositeFilter.doFilter(CompositeFilter.java:65)
	at info.magnolia.cms.filters.AbstractMgnlFilter.doFilter(AbstractMgnlFilter.java:89)
	at info.magnolia.cms.filters.MgnlFilterChain.doFilter(MgnlFilterChain.java:80)
	at info.magnolia.cms.filters.VirtualUriFilter.doFilter(VirtualUriFilter.java:68)
	at info.magnolia.cms.filters.AbstractMgnlFilter.doFilter(AbstractMgnlFilter.java:89)
	at info.magnolia.cms.filters.MgnlFilterChain.doFilter(MgnlFilterChain.java:80)
	at info.magnolia.module.cache.executor.Bypass.processCacheRequest(Bypass.java:58)
	at info.magnolia.module.cache.executor.CompositeExecutor.processCacheRequest(CompositeExecutor.java:66)
	at info.magnolia.module.cache.filter.CacheFilter.doFilter(CacheFilter.java:153)
	at info.magnolia.cms.filters.OncePerRequestAbstractMgnlFilter.doFilter(OncePerRequestAbstractMgnlFilter.java:58)
	at info.magnolia.cms.filters.MgnlFilterChain.doFilter(MgnlFilterChain.java:80)
	at info.magnolia.cms.i18n.I18nContentSupportFilter.doFilter(I18nContentSupportFilter.java:73)
	at info.magnolia.cms.filters.AbstractMgnlFilter.doFilter(AbstractMgnlFilter.java:89)
	at info.magnolia.cms.filters.MgnlFilterChain.doFilter(MgnlFilterChain.java:80)
	at info.magnolia.cms.filters.RangeSupportFilter.doFilter(RangeSupportFilter.java:84)
	at info.magnolia.cms.filters.AbstractMgnlFilter.doFilter(AbstractMgnlFilter.java:89)
	at info.magnolia.cms.filters.MgnlFilterChain.doFilter(MgnlFilterChain.java:80)
	at info.magnolia.cms.security.BaseSecurityFilter.doFilter(BaseSecurityFilter.java:57)
	at info.magnolia.cms.filters.AbstractMgnlFilter.doFilter(AbstractMgnlFilter.java:89)
	at info.magnolia.cms.filters.MgnlFilterChain.doFilter(MgnlFilterChain.java:80)
	at info.magnolia.cms.security.SecurityCallbackFilter.doFilter(SecurityCallbackFilter.java:83)
	at info.magnolia.cms.filters.OncePerRequestAbstractMgnlFilter.doFilter(OncePerRequestAbstractMgnlFilter.java:58)
	at info.magnolia.cms.filters.MgnlFilterChain.doFilter(MgnlFilterChain.java:80)
	at info.magnolia.cms.security.LogoutFilter.doFilter(LogoutFilter.java:93)
	at info.magnolia.cms.filters.OncePerRequestAbstractMgnlFilter.doFilter(OncePerRequestAbstractMgnlFilter.java:58)
	at info.magnolia.cms.filters.MgnlFilterChain.doFilter(MgnlFilterChain.java:80)
	at info.magnolia.module.templatingkit.filters.SiteMergeFilter.doFilter(SiteMergeFilter.java:106)
	at info.magnolia.cms.filters.AbstractMgnlFilter.doFilter(AbstractMgnlFilter.java:89)
	at info.magnolia.cms.filters.MgnlFilterChain.doFilter(MgnlFilterChain.java:80)
	at info.magnolia.cms.filters.MultiChannelFilter.doFilter(MultiChannelFilter.java:82)
	at info.magnolia.cms.filters.OncePerRequestAbstractMgnlFilter.doFilter(OncePerRequestAbstractMgnlFilter.java:58)
	at info.magnolia.cms.filters.MgnlFilterChain.doFilter(MgnlFilterChain.java:80)
	at info.magnolia.module.cache.filter.GZipFilter.doFilter(GZipFilter.java:73)
	at info.magnolia.cms.filters.OncePerRequestAbstractMgnlFilter.doFilter(OncePerRequestAbstractMgnlFilter.java:58)
	at info.magnolia.cms.filters.MgnlFilterChain.doFilter(MgnlFilterChain.java:80)
	at info.magnolia.cms.filters.MgnlFilterChain.doFilter(MgnlFilterChain.java:82)
	at info.magnolia.cms.security.auth.login.LoginFilter.doFilter(LoginFilter.java:104)
	at info.magnolia.cms.filters.AbstractMgnlFilter.doFilter(AbstractMgnlFilter.java:89)
	at info.magnolia.cms.filters.MgnlFilterChain.doFilter(MgnlFilterChain.java:80)
	at info.magnolia.cms.filters.MgnlFilterChain.doFilter(MgnlFilterChain.java:82)
	at info.magnolia.cms.filters.MgnlFilterChain.doFilter(MgnlFilterChain.java:82)
	at info.magnolia.module.devicedetection.filter.DeviceDetectionFilter.doFilter(DeviceDetectionFilter.java:71)
	at info.magnolia.cms.filters.OncePerRequestAbstractMgnlFilter.doFilter(OncePerRequestAbstractMgnlFilter.java:58)
	at info.magnolia.cms.filters.MgnlFilterChain.doFilter(MgnlFilterChain.java:80)
	at info.magnolia.cms.filters.ContentTypeFilter.doFilter(ContentTypeFilter.java:103)
	at info.magnolia.cms.filters.AbstractMgnlFilter.doFilter(AbstractMgnlFilter.java:89)
	at info.magnolia.cms.filters.MgnlFilterChain.doFilter(MgnlFilterChain.java:80)
	at info.magnolia.cms.filters.ContextFilter.doFilter(ContextFilter.java:129)
	at info.magnolia.cms.filters.AbstractMgnlFilter.doFilter(AbstractMgnlFilter.java:89)
	at info.magnolia.cms.filters.MgnlFilterChain.doFilter(MgnlFilterChain.java:80)
	at info.magnolia.cms.filters.CompositeFilter.doFilter(CompositeFilter.java:65)
	at info.magnolia.cms.filters.AbstractMgnlFilter.doFilter(AbstractMgnlFilter.java:89)
	at info.magnolia.cms.filters.SafeDestroyMgnlFilterWrapper.doFilter(SafeDestroyMgnlFilterWrapper.java:106)
	at info.magnolia.cms.filters.MgnlFilterDispatcher.doDispatch(MgnlFilterDispatcher.java:66)
	at info.magnolia.cms.filters.MgnlMainFilter.doFilter(MgnlMainFilter.java:107)
	at info.magnolia.cms.filters.MgnlMainFilter.doFilter(MgnlMainFilter.java:93)
	at org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:243)
	at org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:210)
	at org.apache.catalina.core.StandardWrapperValve.invoke(StandardWrapperValve.java:222)
	at org.apache.catalina.core.StandardContextValve.invoke(StandardContextValve.java:123)
	at org.apache.catalina.authenticator.AuthenticatorBase.invoke(AuthenticatorBase.java:472)
	at org.apache.catalina.core.StandardHostValve.invoke(StandardHostValve.java:171)
	at org.apache.catalina.valves.ErrorReportValve.invoke(ErrorReportValve.java:99)
	at org.apache.catalina.valves.AccessLogValve.invoke(AccessLogValve.java:947)
	at org.apache.catalina.core.StandardEngineValve.invoke(StandardEngineValve.java:118)
	at org.apache.catalina.connector.CoyoteAdapter.service(CoyoteAdapter.java:408)
	at org.apache.coyote.http11.AbstractHttp11Processor.process(AbstractHttp11Processor.java:1009)
	at org.apache.coyote.AbstractProtocol$AbstractConnectionHandler.process(AbstractProtocol.java:589)
	at org.apache.tomcat.util.net.JIoEndpoint$SocketProcessor.run(JIoEndpoint.java:312)
	at java.util.concurrent.ThreadPoolExecutor$Worker.runTask(ThreadPoolExecutor.java:895)
	at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:918)
	at java.lang.Thread.run(Thread.java:680)



 Comments   
Comment by Kevin Coshic [ 10/Feb/14 ]

I have the same problem in Magnolia CMS v5.2.1, and also in v5.2.2.

Comment by Eric Hechinger [ 10/Feb/14 ]

Dear Kevin,

Could you provide us some additional hints, cause I can't reopen this ticket as I just tested it without the mentioned issue with a 5.2.1 and 5.2.2 version.
I created a new default composite field with embedded static and a text field (As in the previous provided screenshot) and did not get exceptions when:

  • editing the dialog for the first time.
  • store the dialog with an empty text value
  • store the dialog with a non empty text value.

Regards

Comment by Kevin Coshic [ 10/Feb/14 ]

Hello Eric

I have a dialog with the next fields:

  • MultiValue Field
  • Composite Field
  • Text Field
  • Link Field
  • Static Field

Only when I have the Static Field, the exception is thrown. Maybe, the solution was only when the Composite Field has a Static Field, but the Composite Field is not inside of a MultiValue Field. ( The english is not my first language, I'm sorry. )

Greetings

Comment by Eric Hechinger [ 11/Feb/14 ]

Hello Kevin

I tried with the 'same' field structure and did not get any exceptions. (see the attached tab definition).

Could you extract your tab or form definition?

Comment by Eric Hechinger [ 11/Feb/14 ]

test field definition

Comment by Kevin Coshic [ 11/Feb/14 ]

MultiValue Field ( Composite Field [ Link Field - Text Field - Static Field ] ) . When the static field is available in the composite field, and the composite field is inside of a MultiValue field the exception is thrown.

Comment by Kevin Coshic [ 11/Feb/14 ]

Hi Eric, see the attached tab definition, please. The tab definition is only an example of the structure of the fields.

Greetings

Comment by Eric Hechinger [ 11/Feb/14 ]

Ok was able to reproduce. Will investigate soon.

Generated at Mon Feb 12 08:55:33 CET 2024 using Jira 9.4.2#940002-sha1:46d1a51de284217efdcb32434eab47a99af2938b.