[MGNLUI-2358] Adapt tests as same-name siblings are no longer allowed Created: 06/Nov/13  Updated: 13/Nov/13  Resolved: 08/Nov/13

Status: Closed
Project: Magnolia UI
Component/s: None
Affects Version/s: 5.2
Fix Version/s: 5.2

Type: Bug Priority: Critical
Reporter: Eric Hechinger Assignee: Eric Hechinger
Resolution: Fixed Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Issue Links:
causality
caused by MGNLUI-2366 Remove unnecessary usage of copyInSes... Closed
caused by MAGNOLIA-5463 Change implementation of copyInSessio... Closed
relation
is related to MAGNOLIA-5434 Default node type definition should n... Closed
Template:
Acceptance criteria:
Empty
Task DoD:
[ ]* Doc/release notes changes? Comment present?
[ ]* Downstream builds green?
[ ]* Solution information and context easily available?
[ ]* Tests
[ ]* FixVersion filled and not yet released
[ ]  Architecture Decision Record (ADR)
Bug DoR:
[ ]* Steps to reproduce, expected, and actual results filled
[ ]* Affected version filled
Sprint: 5.2-rc1

 Description   

The changes introduce by the modification of the nodeType definition in
https://git.magnolia-cms.com/gitweb/?p=magnolia_main.git;a=blob;f=magnolia-core/src/main/resources/mgnl-nodetypes/magnolia-nodetypes.xml;h=69a828e519cc073f3f556510cb8840d9cd0228b1;hb=c6af0a121f025699c509f2f1ecc0a1e0e9feb21c
produces test errors:

Once solve do not forget to

  • reactivate the following test class: DialogMigrationTaskTest
  • increase module coverage to 47
    .
info.magnolia.module.delta.TaskExecutionException: Could not Migrate Dialog 
	at info.magnolia.ui.dialog.setup.DialogMigrationTask.execute(DialogMigrationTask.java:168)
	at info.magnolia.ui.dialog.setup.DialogMigrationTaskTest.testExecuteExtendsMigration(DialogMigrationTaskTest.java:199)
	at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
	at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:39)
	at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25)
	at java.lang.reflect.Method.invoke(Method.java:597)
	at org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(FrameworkMethod.java:47)
	at org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCallable.java:12)
	at org.junit.runners.model.FrameworkMethod.invokeExplosively(FrameworkMethod.java:44)
	at org.junit.internal.runners.statements.InvokeMethod.evaluate(InvokeMethod.java:17)
	at org.junit.internal.runners.statements.RunBefores.evaluate(RunBefores.java:26)
	at org.junit.internal.runners.statements.RunAfters.evaluate(RunAfters.java:27)
	at org.junit.runners.ParentRunner.runLeaf(ParentRunner.java:271)
	at org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:70)
	at org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:50)
	at org.junit.runners.ParentRunner$3.run(ParentRunner.java:238)
	at org.junit.runners.ParentRunner$1.schedule(ParentRunner.java:63)
	at org.junit.runners.ParentRunner.runChildren(ParentRunner.java:236)
	at org.junit.runners.ParentRunner.access$000(ParentRunner.java:53)
	at org.junit.runners.ParentRunner$2.evaluate(ParentRunner.java:229)
	at org.junit.runners.ParentRunner.run(ParentRunner.java:309)
	at org.eclipse.jdt.internal.junit4.runner.JUnit4TestReference.run(JUnit4TestReference.java:50)
	at org.eclipse.jdt.internal.junit.runner.TestExecution.run(TestExecution.java:38)
	at org.eclipse.jdt.internal.junit.runner.RemoteTestRunner.runTests(RemoteTestRunner.java:467)
	at org.eclipse.jdt.internal.junit.runner.RemoteTestRunner.runTests(RemoteTestRunner.java:683)
	at org.eclipse.jdt.internal.junit.runner.RemoteTestRunner.run(RemoteTestRunner.java:390)
	at org.eclipse.jdt.internal.junit.runner.RemoteTestRunner.main(RemoteTestRunner.java:197)
Caused by: javax.jcr.ItemExistsException: Node with the same UUID exists:node /modules/testModule/dialogs
	at org.apache.jackrabbit.core.xml.SessionImporter.startNode(SessionImporter.java:380)
	at org.apache.jackrabbit.core.xml.SysViewImportHandler.processNode(SysViewImportHandler.java:93)
	at org.apache.jackrabbit.core.xml.SysViewImportHandler.startElement(SysViewImportHandler.java:134)
	at org.apache.jackrabbit.core.xml.ImportHandler.startElement(ImportHandler.java:175)
	at org.apache.jackrabbit.commons.xml.DefaultContentHandler.startElement(DefaultContentHandler.java:161)
	at org.apache.xerces.parsers.AbstractSAXParser.startElement(Unknown Source)
	at org.apache.xerces.impl.XMLNSDocumentScannerImpl.scanStartElement(Unknown Source)
	at org.apache.xerces.impl.XMLDocumentFragmentScannerImpl$FragmentContentDispatcher.dispatch(Unknown Source)
	at org.apache.xerces.impl.XMLDocumentFragmentScannerImpl.scanDocument(Unknown Source)
	at org.apache.xerces.parsers.XML11Configuration.parse(Unknown Source)
	at org.apache.xerces.parsers.XML11Configuration.parse(Unknown Source)
	at org.apache.xerces.parsers.XMLParser.parse(Unknown Source)
	at org.apache.xerces.parsers.AbstractSAXParser.parse(Unknown Source)
	at org.apache.xerces.jaxp.SAXParserImpl$JAXPSAXParser.parse(Unknown Source)
	at org.apache.xerces.jaxp.SAXParserImpl.parse(Unknown Source)
	at org.apache.jackrabbit.commons.xml.ParsingContentHandler.parse(ParsingContentHandler.java:62)
	at org.apache.jackrabbit.commons.AbstractSession.importXML(AbstractSession.java:344)
	at info.magnolia.jcr.wrapper.DelegateSessionWrapper.importXML(DelegateSessionWrapper.java:249)
	at info.magnolia.jcr.wrapper.DelegateSessionWrapper.importXML(DelegateSessionWrapper.java:249)
	at info.magnolia.jcr.wrapper.DelegateSessionWrapper.importXML(DelegateSessionWrapper.java:249)
	at info.magnolia.ui.dialog.setup.DialogMigrationTask.copyInSession(DialogMigrationTask.java:490)
	at info.magnolia.ui.dialog.setup.DialogMigrationTask.execute(DialogMigrationTask.java:150)
	... 26 more

Generated at Mon Feb 12 08:55:49 CET 2024 using Jira 9.4.2#940002-sha1:46d1a51de284217efdcb32434eab47a99af2938b.