[MGNLUI-2431] i18n:pageEditor i18n is broken - always uses english for some keys Created: 16/Sep/13  Updated: 09/Mar/21  Resolved: 09/Mar/21

Status: Closed
Project: Magnolia UI
Component/s: None
Affects Version/s: None
Fix Version/s: None

Type: Bug Priority: Major
Reporter: Christoph Meier Assignee: Unassigned
Resolution: Obsolete Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Attachments: PNG File en-de-mix-3_opener-auftakt.png     PNG File en-de-mix.png     PNG File en-de-mix_2.png     PNG File missing-de_fusszeilen_at_home.png     PNG File missing-de_metas_at_home.png     PNG File missing-de_promos_at_home.png.png    
Template:
Acceptance criteria:
Empty
Task DoD:
[ ]* Doc/release notes changes? Comment present?
[ ]* Downstream builds green?
[ ]* Solution information and context easily available?
[ ]* Tests
[ ]* FixVersion filled and not yet released
[ ]  Architecture Decision Record (ADR)
Bug DoR:
[ ]* Steps to reproduce, expected, and actual results filled
[ ]* Affected version filled
Date of First Response:

 Description   

create new message-bundles each for stk (according to new i18n-concept)

There is a problem in that some of the values are always in english - no matter the set language.
Usually "New" and "Component" are in english.



 Comments   
Comment by Christoph Meier [ 18/Nov/13 ]

Some of the texts in STK are somehow strange assembled which leads into language-mix-labels. (see screenshot)

Comment by Christopher Zimmermann [ 19/Nov/13 ]

These strings appear to be assembled at:
/magnolia-ui-widget-editor/src/main/java/info/magnolia/ui/vaadin/gwt/client/editor/dom/MgnlArea.java

line 187:
getPlaceHolderLabel()
labelString = getI18nMessage("buttons.new.js") + " " + label + " " + getI18nMessage("buttons.component.js");

Somehow getI18nMessage appears to be operating in english even if another language is specified.
Its client code. (The keys for the two values do exist in german & chinese language bundles.)

Looks like its a problem with how values are put into the dictionary used by:

public static String getI18nMessage(final String key)

{ return dictionary.get(key); }

Huh - what is this?
static

{ //TODO these calls raise an error //JavascriptUtils.exposeMgnlMessagesToGwtDictionary("info.magnolia.module.admininterface.messages"); //dictionary = Dictionary.getDictionary("mgnlGwtMessages"); }
Generated at Mon Feb 12 08:56:33 CET 2024 using Jira 9.4.2#940002-sha1:46d1a51de284217efdcb32434eab47a99af2938b.