[MGNLUI-2491] Revert changes in MGNLUI-2369 and use proper solution Created: 05/Dec/13  Updated: 10/Dec/13  Resolved: 05/Dec/13

Status: Closed
Project: Magnolia UI
Component/s: None
Affects Version/s: 5.2
Fix Version/s: 5.2.1

Type: Bug Priority: Neutral
Reporter: Jaroslav Simak Assignee: Jaroslav Simak
Resolution: Fixed Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Issue Links:
relation
is related to MGNLACTIVATION-68 Register activation app into appLaunc... Closed
Template:
Acceptance criteria:
Empty
Task DoD:
[ ]* Doc/release notes changes? Comment present?
[ ]* Downstream builds green?
[ ]* Solution information and context easily available?
[ ]* Tests
[ ]* FixVersion filled and not yet released
[ ]  Architecture Decision Record (ADR)
Bug DoR:
[ ]* Steps to reproduce, expected, and actual results filled
[ ]* Affected version filled
Date of First Response:

 Description   

Registration of activation app to appLauncher shouldn't be done this way.
Better is to:

  • add optional dependency on ui-admincentral - activation will install after admincentral module thus we can use mgnl-bootstrap folder to register activation app to applauncher (see Federico's comment)
  • put .xml bootstrap file under mgnl-bootstrap/ui-admincentral - file will be bootstrapped on ui-admincentral module install


 Comments   
Comment by Federico Grilli [ 05/Dec/13 ]

Watch out, afaik activation should be installed before any module registering a workspace (see info.magnolia.module.delta.SetupModuleRepositoriesTask.subscribeRepository(String)), so moving activation after ui-admincentral wouldn't work given that ui-admincentral depends on imaging module which in turn registers the imaging workspace.

Comment by Jaroslav Simak [ 05/Dec/13 ]

Actually i used 2nd solution and everything works fine on my env.

Generated at Mon Feb 12 08:57:09 CET 2024 using Jira 9.4.2#940002-sha1:46d1a51de284217efdcb32434eab47a99af2938b.