[MGNLUI-2530] Error messages should not be sent to all users, but rather to the current user Created: 18/Dec/13 Updated: 19/Dec/13 Resolved: 18/Dec/13 |
|
| Status: | Closed |
| Project: | Magnolia UI |
| Component/s: | framework |
| Affects Version/s: | 5.2.1 |
| Fix Version/s: | 5.2.1 |
| Type: | Improvement | Priority: | Blocker |
| Reporter: | Christopher Zimmermann | Assignee: | Christopher Zimmermann |
| Resolution: | Fixed | Votes: | 0 |
| Labels: | None | ||
| Remaining Estimate: | Not Specified | ||
| Time Spent: | Not Specified | ||
| Original Estimate: | Not Specified | ||
| Issue Links: |
|
||||||||||||||||||||||||
| Template: |
|
||||||||||||||||||||||||
| Acceptance criteria: |
Empty
|
||||||||||||||||||||||||
| Task DoD: |
[ ]*
Doc/release notes changes? Comment present?
[ ]*
Downstream builds green?
[ ]*
Solution information and context easily available?
[ ]*
Tests
[ ]*
FixVersion filled and not yet released
[ ] 
Architecture Decision Record (ADR)
|
||||||||||||||||||||||||
| Release notes required: |
Yes
|
||||||||||||||||||||||||
| Date of First Response: | |||||||||||||||||||||||||
| Description |
|
Many error messages are sent to all users via a call to AppInstanceController#broadcastMessage A short search reveals calls to broadcastMessage when actions fail in BaseDialogPresenter, DetailEditorPresenter, DetailPresenter. A complete search on entire codebase must still be performed. * The current required fix for this ticket is to find and replace usages of broadcastMessage with sendLocalMessage (which sends a message to the user who triggered the error). |
| Comments |
| Comment by Tom Wespi [ 18/Dec/13 ] |
|
Sending the error message just to current user is imho not a good solutions, due the superuser (or all users with the role superuser) should see the error messages. A normal user e.g. an editor, is not interested to see magnolia error messages. |
| Comment by Christopher Zimmermann [ 19/Dec/13 ] |
|
Thanks for your input Tom. The current user should see the error because probably the action they were trying to perform failed, and they should be aware of that. I agree that it could make sense for the superuser to get a message as well, but we'd like to put more care into how that happens. The calls that were changed in this ticket were for every single exception when an action is performed and this leads to high noise for the superusers inbox. |