[MGNLUI-2557] Show permissions in status column Created: 09/Jan/14  Updated: 29/Oct/15  Resolved: 31/Jan/14

Status: Closed
Project: Magnolia UI
Component/s: workbench
Affects Version/s: 5.0
Fix Version/s: 5.2.2

Type: Bug Priority: Neutral
Reporter: Roman Kovařík Assignee: Roman Kovařík
Resolution: Fixed Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Attachments: File 143-read-only.svg     PNG File Bildschirmfoto 2014-01-13 um 11.43.28.png     PNG File MAG_Design_Icon_Read_only_140120.png     JPEG File Screen Shot 2014-01-31 at 08.49.55.jpg     PNG File implemented.png    
Issue Links:
Relates
relates to MGNLUI-2510 UI shouldn't enable actions for which... Closed
Template:
Acceptance criteria:
Empty
Task DoD:
[ ]* Doc/release notes changes? Comment present?
[ ]* Downstream builds green?
[ ]* Solution information and context easily available?
[ ]* Tests
[ ]* FixVersion filled and not yet released
[ ]  Architecture Decision Record (ADR)
Bug DoR:
[ ]* Steps to reproduce, expected, and actual results filled
[ ]* Affected version filled
Release notes required:
Yes
Date of First Response:

 Description   

We can see read only icon next to the status icon in the tree when the page is read-only in Magnolia 4.5 (not only website tree).
We should visualize this also in Magnolia 5.

Investigation: already implemented, but:

  1. It's disabled by default
  2. It's buggy:
    Caused by: java.security.AccessControlException: add_node,remove,set_property
    	at org.apache.jackrabbit.core.SessionImpl.checkPermission(SessionImpl.java:708)
    	at info.magnolia.jcr.wrapper.DelegateSessionWrapper.checkPermission(DelegateSessionWrapper.java:109)
    	at info.magnolia.jcr.wrapper.DelegateSessionWrapper.checkPermission(DelegateSessionWrapper.java:109)
    	at info.magnolia.jcr.wrapper.DelegateSessionWrapper.checkPermission(DelegateSessionWrapper.java:109)
    	at info.magnolia.ui.workbench.column.StatusColumnFormatter.generateCell(StatusColumnFormatter.java:97)
    	at com.vaadin.ui.Table.parseItemIdToCells(Table.java:2312)
    	at com.vaadin.ui.Table.getVisibleCellsNoCache(Table.java:2173)
    	at com.vaadin.ui.Table.refreshRenderedCells(Table.java:1694
    
  3. If enabled and fixed, status icon overlaps permission icon.


 Comments   
Comment by Christoph Meier [ 13/Jan/14 ]

Andreas is not happy with that "old" icon. The UX-team will discuss it this week and deliver a new icon or give the okay for.

(I add screenshots for the UI-Team as discussion-base.)

Comment by Andreas Weder [ 13/Jan/14 ]

Attached a screenshot of how this looked in 4.5.

Comment by Daniel Lipp [ 21/Jan/14 ]

FYI: icon should be delivered today...

Comment by Andreas Weder [ 21/Jan/14 ]

Here's the icon as well as a screen shot showing how it should be used.

Comment by Andreas Weder [ 21/Jan/14 ]

Assigned the issue to Mikael temporarily, as he's going to add the new icon to our icon font.

Comment by Mikaël Geljić [ 21/Jan/14 ]

Done integrating new readonly icon into the font. Use class name "icon-read-only".

Side-note/For the story, I had to cleanup the SVG manually because it contained original source paths and additional useless background paths... It's somewhat similar to the problems we had with 'inverted' icons at some point, except this time it was just a plain black square.

Comment by Mikaël Geljić [ 29/Jan/14 ]

1. Only read-only pages should have an icon
2. icon vertical alignment and coloring needs to be fixed
– HINT: add a style rule for .icon-read-only in workbench.scss
— same flavor as activation-status
— font-size: 18px;
— color: $c10; (#666)

Comment by Daniel Lipp [ 31/Jan/14 ]

Read-only icon gets hidden behind the selection bar.

Comment by Roman Kovařík [ 31/Jan/14 ]

Fixed color when row is selected implemented.png

Generated at Mon Feb 12 08:57:52 CET 2024 using Jira 9.4.2#940002-sha1:46d1a51de284217efdcb32434eab47a99af2938b.