[MGNLUI-2599] Favorite groups not creatable on the fly - what you type is ignored Created: 17/Jan/14  Updated: 19/Jun/15  Resolved: 16/May/14

Status: Closed
Project: Magnolia UI
Component/s: favorites
Affects Version/s: 5.0.1, 5.2.1
Fix Version/s: 5.2.5

Type: Bug Priority: Major
Reporter: Rainer Blumenthal Assignee: Christoph Meier
Resolution: Fixed Votes: 0
Labels: aperto, next, support, usability, ux
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Attachments: JPEG File screenshot-1.jpg    
Issue Links:
Cloners
clones MGNLUI-2598 Rename/delete actions in favourites a... Closed
relation
Template:
Acceptance criteria:
Empty
Task DoD:
[ ]* Doc/release notes changes? Comment present?
[ ]* Downstream builds green?
[ ]* Solution information and context easily available?
[ ]* Tests
[ ]* FixVersion filled and not yet released
[ ]  Architecture Decision Record (ADR)
Bug DoR:
[ ]* Steps to reproduce, expected, and actual results filled
[ ]* Affected version filled
Date of First Response:

 Description   

If I want to create a favorite in a new group, I have to create the group first - and lose my favorite.
The input fields shows a cursor, and if I enter something ... I expect the group to be created.

  • either make it a dropdown only, or save on the fly would be a solution.

See attached screenshot.



 Comments   
Comment by Andreas Weder [ 23/Jan/14 ]

This is very confusing behavior indeed.

Let me add this to our queue of usability issues we plan to look at for maintenance releases or 5.3. The combobox should at least be read-only, since you currently can't create a new group and a new favorite at the same time. But I would like to research also adding that feature now because it would be so handy to have that.

Comment by Christoph Meier [ 08/May/14 ]

if possible: allow to add a group at the same time as adding the bookmark
if not possible: set the group-"dropdown" to read-only and display an invitation (e.g. "you may add the bookmark to a group") if there is already a group

Comment by Christoph Meier [ 12/May/14 ]

Commited onto branch "MGNLUI-2599"
(See https://git.magnolia-cms.com/gitweb/?p=magnolia_ui.git;a=commit;h=5a43a7426c09d0bb1440a422ba3a1990ebb099be )

Comment by Daniel Lipp [ 14/May/14 ]

FavoritesView#addFavoriteAndGroup

  • this is not valid javadoc -> pls explain the params
    FavoritesPresenter
  • quite some changes, pls cover with unit-tests
    FavoriteForm
  • heave changes: if it can be covered by unit-tests with reasonable effort, do it

in general:

  • add one or more UI-tests to cover the verify the new behavior
Comment by Christoph Meier [ 15/May/14 ]

Added a new UI-Test; committed onto branch "MGNLUI-2599" on ce-bundle.
(Last commit, see https://git.magnolia-cms.com/gitweb/?p=ce-bundle.git;a=commit;h=8fa9bc4719047349e5eb545520f7ab843e9f2cea )

Comment by Christoph Meier [ 15/May/14 ]

Added a minor fix/improvement on FavoritesPresenter, added and corrected javadoc and added unit-test.
(Check commits on https://git.magnolia-cms.com/gitweb/?p=magnolia_ui.git;a=shortlog;h=refs/heads/MGNLUI-2599 )

Comment by Daniel Lipp [ 16/May/14 ]

fix javadoc of FavoritesPresenter:

e.g. javadoc like
/**

  • Constructor.
  • @param view
  • @param favoritesManager
  • @param appDescriptorRegistry
  • @param i18nizer
    */

is worse than no javadoc.

Comment by Christoph Meier [ 16/May/14 ]

5.2.x
Changes in UI (magnolia-ui-5.2.x) and the UI-Test on ce-bundle (magnolia-bundle-5.2.x); both committed.

For 5.3,
UI is commited onto master, but the UI-tests on ce-bundle is not yet on master but on branch "MGNLUI-2599-UI-Test" (See https://git.magnolia-cms.com/gitweb/?p=ce-bundle.git;a=commit;h=bef7f68ba061c0a40d54f03442649c014f12c2d0).
Must be added to master, when the next UI-milestone which contains the UI-changes for this ticket is on the master-ce-bundle

Generated at Mon Feb 12 08:58:17 CET 2024 using Jira 9.4.2#940002-sha1:46d1a51de284217efdcb32434eab47a99af2938b.