[MGNLUI-2614] Improve action buttons so that even if label is too long it is still displayed. Created: 21/Jan/14 Updated: 16/Jan/20 Resolved: 13/Jan/20 |
|
| Status: | Closed |
| Project: | Magnolia UI |
| Component/s: | actionbar |
| Affects Version/s: | 5.2.1 |
| Fix Version/s: | 6.2 |
| Type: | Bug | Priority: | Major |
| Reporter: | Christopher Zimmermann | Assignee: | Lam Nguyen Bao |
| Resolution: | Fixed | Votes: | 0 |
| Labels: | next, quickwin | ||
| Remaining Estimate: | 0d | ||
| Time Spent: | 2d | ||
| Original Estimate: | 1.5d | ||
| Attachments: |
|
||||||||||||
| Issue Links: |
|
||||||||||||
| Template: |
|
||||||||||||
| Acceptance criteria: |
Empty
|
||||||||||||
| Task DoD: |
[ ]*
Doc/release notes changes? Comment present?
[ ]*
Downstream builds green?
[ ]*
Solution information and context easily available?
[ ]*
Tests
[ ]*
FixVersion filled and not yet released
[ ] 
Architecture Decision Record (ADR)
|
||||||||||||
| Bug DoR: |
[ ]*
Steps to reproduce, expected, and actual results filled
[ ]*
Affected version filled
|
||||||||||||
| Date of First Response: | |||||||||||||
| Epic Link: | Support | ||||||||||||
| Sprint: | SPA Editor 14 | ||||||||||||
| Story Points: | 3 | ||||||||||||
| Description |
|
It often happens that when an i18n value does not exist that the entire key is written to a button in the action bar - but because of styling, the text is wrapped to a row that is not visible. This confuses developers as they think it is a code issue responsible for no key showing up. |
| Comments |
| Comment by Richard Gange [ 24/Jun/19 ] |
|
As a workaround you should be able to see the entire key through Firebug or some similar browser debugging tool. |
| Comment by Lam Nguyen Bao [ 08/Jan/20 ] |
|
Hi czimmermann,
Just an example to show "How it will be". I changed css for make behavior consistent as new UI. Thanks, Lam Nguyen |
| Comment by Richard Gange [ 08/Jan/20 ] |
|
Would it be a large effort to have some toggle switch? Show to the key or show nothing? |
| Comment by Lam Nguyen Bao [ 08/Jan/20 ] |
|
"toggle switch" does same as default value if the translation id is broken? please give me an example. Also that, if you show nothing then there's two cases happen: someone define an empty value or the id value is broken. In my opinion, we just show as it is and end user immediately have awareness about what is going on. |
| Comment by Richard Gange [ 08/Jan/20 ] |
|
The problem has been with Blossom. It seems we add these new features to templating, such as, the placeholder text but we don't consider how that impacts those using Blossom templates. SUPPORT-10685 For years we didn't show the key. If nothing was found then nothing was shown. Then we seemed to reverse that. I would think that if I am in development mode then I'd want to see the key. If not, then showing nothing (assuming no key exists or the key is empty). |
| Comment by Christopher Zimmermann [ 08/Jan/20 ] |
|
We should keep the height locked to one row but just have text run off of the right side. We should only change M5, the M6 behaviour is acceptable, but will likely be changed soon as it is not behaving as specified by UX. |
| Comment by Lam Nguyen Bao [ 10/Jan/20 ] |
|
czimmermann, I keep the height looked and the text run off the right side your comments.
|
| Comment by Lam Nguyen Bao [ 10/Jan/20 ] |
|
Be noticed that, "text-overflow: ellipsis" is conflicted with "text-indent" in recently versions of chrome. Hence the end user is unable to see '...' once text run off the line. The other browsers is working well. For more information, please check: https://bugs.chromium.org/p/chromium/issues/detail?id=1006395#c5 |