[MGNLUI-2622] Show activation status on a status bar at the bottom of PageEditor Created: 23/Jan/14  Updated: 06/May/14  Resolved: 16/Apr/14

Status: Closed
Project: Magnolia UI
Component/s: app framework, page editor, pages app
Affects Version/s: None
Fix Version/s: 5.2.4

Type: Improvement Priority: Neutral
Reporter: Zdenek Skodik Assignee: Jaroslav Simak
Resolution: Fixed Votes: 1
Labels: next, statusbar, support, usability, ux
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Attachments: PNG File 1 Status bar too high.png     PNG File 2 Not vertically aligned.png     PNG File 3 Not vertically aligned.png     PNG File page-editor-status-green.png     PNG File page-editor-status-orange.png     PNG File page-editor-status-red.png    
Issue Links:
causality
is causing MGNLUI-2815 Activation status on bottom of PageEd... Closed
relation
is related to MGNLUI-2813 Activation status in editor is not re... Closed
Template:
Acceptance criteria:
Empty
Task DoD:
[ ]* Doc/release notes changes? Comment present?
[ ]* Downstream builds green?
[ ]* Solution information and context easily available?
[ ]* Tests
[ ]* FixVersion filled and not yet released
[ ]  Architecture Decision Record (ADR)
Release notes required:
Yes
Date of First Response:

 Description   

It has been requested for some time that we show the publication state of a page in the page editor and the page preview. The status bar at the bottom has been designed to do this.

  • research the current status of the bar: can it be extended already
  • could/should we add an indicator for the publication state of a page in maintenance


 Comments   
Comment by Mikaël Geljić [ 10/Feb/14 ]

We specified showing activation status in page-editor as follows:

  • We display the activation status as icon + label, centered in status bar below page-editor.
    • We add a third component to page-editor's VerticalLayout, i.e. use a StatusBarView
    • We remove 40px bottom padding from this page-editor layout
  • Visual styles
    • Text is font-size 13px, color #666 ($c10)
    • Icon has same class names as in StatusColumnFormatter: icon-shape-circle + activation-status + color-(green|yellow|red)
    • In particular we should pay attention to vertical align between icon and text.
  • We may even consider finally using the different icon shapes per status instead of icon-shape-circle
    • icon-status-green, icon-status-orange, icon-status-red
    • Apply them to StatusColumnFormatter too.

See attached screenshots.

Comment by Jaroslav Simak [ 04/Apr/14 ]

Commit:
https://git.magnolia-cms.com/gitweb/?p=magnolia_ui.git;a=commitdiff;h=87937e0518b89ce2a8c2ea508b4c08b6c839a223;hp=33668ff89ac38484f93543e9cead3bd869768247

Comment by Roman Kovařík [ 07/Apr/14 ]

Please put back the old constructor and mark it as deprecated to preserve binary compatibility.

Comment by Daniel Lipp [ 14/Apr/14 ]

Initially the new status indicator displays the proper status - but unfortunately it's not refreshed when you navigate to any other page within the page editor.

to reproduce:

  • modify about page
  • open page editor on about page -> proper status (yellow, modified)
  • navigate to "News and Events" from within the page editor -> wrong status (still yellow, modified but this page should get "green, publishes")

when you close the page editor and navigate to "News and Events" within the pages app, then open the editor sub app, you'll get the proper status...

Comment by Andreas Weder [ 15/Apr/14 ]

I've re-opened this issue since I've found two problems during the review:

  • The status bar is too high now. It should only be as high as the area below the Action bar (40 px, if I remember correctly).
  • The icon and label are not vertically aligned.
Generated at Mon Feb 12 08:58:31 CET 2024 using Jira 9.4.2#940002-sha1:46d1a51de284217efdcb32434eab47a99af2938b.