[MGNLUI-2650] Nodes with colons not visible in JCR Browser Created: 03/Feb/14  Updated: 05/Dec/14  Resolved: 23/Jul/14

Status: Closed
Project: Magnolia UI
Component/s: workbench
Affects Version/s: 5.2.1
Fix Version/s: 5.2.8, 5.3.2

Type: Bug Priority: Major
Reporter: Antti Hietala Assignee: Philip Mundt
Resolution: Fixed Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Attachments: PNG File 4.5-jcr-browser-imaging.png     PNG File 5.2-jcr-browser-imaging.png     PNG File content-connector-config.png     PNG File jcr-browser-dam.png     PNG File result-of-content-connector-config-with-system-props.png     PNG File result-of-content-connector-config.png    
Issue Links:
Relates
relates to MGNLDATA-256 EditDataActionDefinition does not sup... Closed
relates to DOCU-528 Improve and complete possible configu... Closed
relation
is related to MGNLUI-3021 Provide ability to display system pro... Closed
Template:
Acceptance criteria:
Empty
Task DoD:
[ ]* Doc/release notes changes? Comment present?
[ ]* Downstream builds green?
[ ]* Solution information and context easily available?
[ ]* Tests
[ ]* FixVersion filled and not yet released
[ ]  Architecture Decision Record (ADR)
Bug DoR:
[ ]* Steps to reproduce, expected, and actual results filled
[ ]* Affected version filled
Date of First Response:

 Description   

Workbench cannot display nodes that contain a colon character. The Imaging module generates such nodes: jcr:content. This change was introduced with the move from DMS to DAM. In 4.5 the same node was named document and a JCR browser tree was able to display it.

4.5: /pop/promo/dms/demo-project/img/bk/Opener/coral-light/document
5.2: /pop/promo/dam/demo-project/img/bk/Opener/coral-light/jcr:content

This issue impacts users because trees like /trees/imaging will be phased out and replaced by the JCR Browser. A user cannot inspect the imaging workspace and learn how the rendition generation works, for example.

The issue is actually a combination of a not proper config (see attached screenshot for a correct one)

  • includeSystemNodes should be specified as true
  • a mgnl:resource nodeType missing in the configuration . This causes the generated query not to contain mgnl:resource which is subnode of jcr:content.

Still with this configuration jcr and mgnl properties are not visible which may not be the desired behaviour for a JCR browser. Reason for that is the hardcoded skipping of system properties at info.magnolia.ui.workbench.tree.HierarchicalJcrContainer.getChildren(Item) (see: MGNLUI-3021).



 Comments   
Comment by Antti Hietala [ 22/Jul/14 ]

Per discussion with pmundt, resolve as:

  • Add the includeSystemNodes property to the content connector of the Configuration app and set it to false by default. This will hide system nodes by default but makes it easy for a user to display them. Document a procedure for changing the value.
  • Add mgnl:resource to the node types displayed by the content connector.
Comment by Philip Mundt [ 22/Jul/14 ]

If a user requires the JCR Browser to work with DAM workspace, one has to add more nodeTypes to the configuration, mainly:

  • mgnl:asset
  • mgnl:folder

See: jcr-browser-dam.png

Comment by Philip Mundt [ 23/Jul/14 ]

After discussions it was decided to simply add the property includeSystemNodes=false to the contentConnector (5.3.x) / workbench (5.2.x) definitions of the websiteJCRBrowser so that users can decide whether to turn it on or not. We do not add additional nodeTypes to this config, as it is not required for the website workspace (which doesn't contain much binary data). We will however improve documentation of possible configuration scenarios.

Comment by Philip Mundt [ 23/Jul/14 ]

RE QA: Ideally

won't show any new deltas in ui-admincentral.

Generated at Mon Feb 12 08:58:48 CET 2024 using Jira 9.4.2#940002-sha1:46d1a51de284217efdcb32434eab47a99af2938b.