[MGNLUI-2663] Annotate CheckboxFieldDefinition#getButtonLabel() with @I18nText Created: 10/Feb/14  Updated: 04/Mar/14  Resolved: 28/Feb/14

Status: Closed
Project: Magnolia UI
Component/s: dialogs
Affects Version/s: None
Fix Version/s: 5.2.3

Type: Bug Priority: Neutral
Reporter: Zdenek Skodik Assignee: Roman Kovařík
Resolution: Fixed Votes: 0
Labels: quickwin, support
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Issue Links:
causality
is causing MAGNOLIA-5700 Add i18n properties for checkboxes Closed
relation
Template:
Acceptance criteria:
Empty
Task DoD:
[ ]* Doc/release notes changes? Comment present?
[ ]* Downstream builds green?
[ ]* Solution information and context easily available?
[ ]* Tests
[ ]* FixVersion filled and not yet released
[ ]  Architecture Decision Record (ADR)
Bug DoR:
[ ]* Steps to reproduce, expected, and actual results filled
[ ]* Affected version filled
Release notes required:
Yes
Date of First Response:

 Description   

So that it's a subject of internationalization, like labels of other fields.
As sideeffect of this fix, wee need to add labels for all checkboxes, see MAGNOLIA-5700.



 Comments   
Comment by Roman Kovařík [ 14/Feb/14 ]

Commited on 5.2.x branch for review.

Comment by Roman Kovařík [ 26/Feb/14 ]

Reopened:

causes issue with i18nized checkbox buttonLabels, e.g. in security users dialog http://hudson.magnolia-cms.com/view/Product_Team/job/magnolia-bundle_5.2.x-with-selenium_profile/ws/magnolia-integration-tests/tests/target/surefire-reports/SecurityAppUITest_testCreateFolderCopyAndDragAndDropSystemUser_192_By.xpath%253A+%252F%252Fdiv%255Bcontains%2528%2540class%252C+%2527v-form-field-section%2527%2529%255D%252Fdiv%255Bcontains%2528text%2528%2529%252C+%2527Password%2527%2529%255D%252Ffollowing-sibling%253A%253Ad.png
we need to add the key with empty value to translation files (there was no label previously)
Mikael Geljic
3:54 PM
And we should pbly check as well whether there are other similar cases in other apps/modules :/

Comment by Roman Kovařík [ 28/Feb/14 ]

Back to resolved -> follow up ticket MAGNOLIA-5700.

Generated at Mon Feb 12 08:58:56 CET 2024 using Jira 9.4.2#940002-sha1:46d1a51de284217efdcb32434eab47a99af2938b.