[MGNLUI-2671] Ensure consistent button order in alerts and dialogs Created: 12/Feb/14 Updated: 06/May/14 Resolved: 20/Mar/14 |
|
| Status: | Closed |
| Project: | Magnolia UI |
| Component/s: | dialogs |
| Affects Version/s: | 5.2.1, 5.2.2 |
| Fix Version/s: | 5.2.4 |
| Type: | Bug | Priority: | Neutral |
| Reporter: | Rainer Blumenthal | Assignee: | Mikaël Geljić |
| Resolution: | Fixed | Votes: | 0 |
| Labels: | next, quickwin, support, ux | ||
| Remaining Estimate: | Not Specified | ||
| Time Spent: | Not Specified | ||
| Original Estimate: | Not Specified | ||
| Attachments: |
|
||||||||
| Issue Links: |
|
||||||||
| Template: |
|
||||||||
| Acceptance criteria: |
Empty
|
||||||||
| Task DoD: |
[ ]*
Doc/release notes changes? Comment present?
[ ]*
Downstream builds green?
[ ]*
Solution information and context easily available?
[ ]*
Tests
[ ]*
FixVersion filled and not yet released
[ ] 
Architecture Decision Record (ADR)
|
||||||||
| Bug DoR: |
[ ]*
Steps to reproduce, expected, and actual results filled
[ ]*
Affected version filled
|
||||||||
| Date of First Response: | |||||||||
| Visible to: |
Rainer Blumenthal
|
||||||||
| Description |
|
This is a minor thing, but I think a good product has to take care for this: In some dialogs the "NO" (negative) is on the left side. In others the "NO" is on the right side. "Confirm" should always be on the same side. You can work much more intuitive then. See screenshots. |
| Comments |
| Comment by Andreas Weder [ 28/Feb/14 ] |
|
Thanks for spotting this. Yes, there's a mixture currently, and we have to take care of that. However, this is because alerts are currently not looking as designed, and we got stuck half way implementing that design. Since the buttons in alerts are currently centered horizontally, the default button should be on the left (that's according to studies/best practice) and it should be "yes"/"ok". So the order is actually right. However, what is wrong currently is that we make the button on the right the default button - it should be the button on the left. The visual design actually calls for these alert buttons to be right aligned, as we do in dialogs currently (see screenshot I attached). Once that is fixed, the default button should then go to the right and the button order be reversed (left: "no", right: "yes") - the order in the screenshot I attached is actually wrong as well (sigh). Because we do not want such a mix up, I want to fix this rather sooner than later. |
| Comment by Mikaël Geljić [ 03/Apr/14 ] |
|
commit is on confirm-dialogs-5.2.4 branch (and actually has wrong commit number - 2761 instead of 2671) https://git.magnolia-cms.com/gitweb/?p=magnolia_ui.git;a=commit;h=2c896e8a02a7c7c2aa116538c9c7a393e1518f4c |