[MGNLUI-2701] Multiple submissions of single publication possible within pages app, producing erroneous change requests Created: 19/Feb/14  Updated: 04/Jun/14  Resolved: 04/Jun/14

Status: Closed
Project: Magnolia UI
Component/s: page editor
Affects Version/s: 5.2.2
Fix Version/s: 5.2.7, 5.3

Type: Bug Priority: Major
Reporter: Dean Pullen Assignee: Jaroslav Simak
Resolution: Fixed Votes: 0
Labels: next, support, usability, ux
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified
Environment:

OSX, Safari, Chrome etc


Issue Links:
relation
is related to MGNLUI-2578 Double Clicking on an Action Should N... Closed
Template:
Acceptance criteria:
Empty
Task DoD:
[ ]* Doc/release notes changes? Comment present?
[ ]* Downstream builds green?
[ ]* Solution information and context easily available?
[ ]* Tests
[ ]* FixVersion filled and not yet released
[ ]  Architecture Decision Record (ADR)
Bug DoR:
[ ]* Steps to reproduce, expected, and actual results filled
[ ]* Affected version filled
Date of First Response:

 Description   

When executing the Publish action within the pages app, you can (quickly) click on the 'SAVE CHANGES' button more than once before the 'Submit for publication' dialog is submitted.

This will result in more than one publish request, one of which will fail due to no 'version' being found in the JCR:

javax.jcr.version.VersionException: Version {}1.100 does not exist.
at org.apache.jackrabbit.core.version.InternalVersionHistoryImpl.getVersion(InternalVersionHistoryImpl.java:277)
at org.apache.jackrabbit.core.version.VersionHistoryImpl.getVersion(VersionHistoryImpl.java:138)
at info.magnolia.cms.core.version.BaseVersionManager.getVersion(BaseVersionManager.java:335)
at info.magnolia.cms.core.DefaultContent.getVersionedContent(DefaultContent.java:500)



 Comments   
Comment by Daniel Lipp [ 21/Feb/14 ]

Hi Dean,

As you might have realized I moved that ticket to MGNLUI.

Thx for reporting
Daniel

Comment by Richard Unger [ 18/Mar/14 ]

+1

Comment by Jan Haderka [ 18/Apr/14 ]

maybe the default behaviour should be changed showing user message asking if they really want to publish the page since nothing has changed since last publication (when page is already marked as activated and not modified).

Comment by Richard Unger [ 22/Apr/14 ]

To be honest, what we would really want here is direct feedback for the user that prevents him invoking the unneeded action in the first place. Something like:

--> when user chooses publish, the icon(s) for the content being published change from red (or yellow) to 'spinner'
--> when publish command completes, the icon changes from 'spinner' to:

  • if activation is complete, status changes to green
  • if activation is pending workflow completion (ie content is in workflow) icon changes to a 'clock'-style icon to signify content is in workflow
    --> tooltips on the icons give textual description of state

in other words the concept of "activation status", at least in terms of display in the UI, needs to get a bit more complicated, and explicitly accommodate and display the "in Workflow" status.

Comment by Jan Haderka [ 25/May/14 ]

removed. thx for spotting it.

Comment by Mikaël Geljić [ 27/May/14 ]

Alright, QA was done successfully, just reopening by the time it gets integrated to 5.2.x. — that is most likely after 5.2.5 is out. I updated fixVersion accordingly.

Generated at Mon Feb 12 08:59:17 CET 2024 using Jira 9.4.2#940002-sha1:46d1a51de284217efdcb32434eab47a99af2938b.