[MGNLUI-2714] FormDialogPresenter does not i18n-decorate the definition correctly Created: 27/Feb/14  Updated: 06/May/14  Resolved: 27/Feb/14

Status: Closed
Project: Magnolia UI
Component/s: None
Affects Version/s: 5.2.2
Fix Version/s: 5.2.3

Type: Bug Priority: Neutral
Reporter: Espen Jervidalo Assignee: Espen Jervidalo
Resolution: Fixed Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Issue Links:
causality
is causing MGNLWORKFLOW-214 Editors do not get notified when a pu... Closed
Template:
Acceptance criteria:
Empty
Task DoD:
[ ]* Doc/release notes changes? Comment present?
[ ]* Downstream builds green?
[ ]* Solution information and context easily available?
[ ]* Tests
[ ]* FixVersion filled and not yet released
[ ]  Architecture Decision Record (ADR)
Bug DoR:
[ ]* Steps to reproduce, expected, and actual results filled
[ ]* Affected version filled

 Description   

Actions on FormDialogs are currently not decorated for i18n.
The reason is in these two methods:

  • info.magnolia.ui.dialog.formdialog.FormDialogPresenterImpl#start(final Item item, FormDialogDefinition dialogDefinition, final UiContext uiContext, EditorCallback callback)
    the definition is set and decorated in the super method and is accessible using the getter, but instead of getting the decorated definition, we set the undecorated object to the action executor.
  • info.magnolia.ui.dialog.formdialog.FormDialogPresenterImpl#buildView
    instead of passing the decorated definition, we re-decorate the passed parameter.

Generated at Mon Feb 12 08:59:25 CET 2024 using Jira 9.4.2#940002-sha1:46d1a51de284217efdcb32434eab47a99af2938b.