[MGNLUI-2729] Choose dialog should not allow selection of multiple items in the UI Created: 05/Mar/14  Updated: 05/Dec/14  Resolved: 20/Oct/14

Status: Closed
Project: Magnolia UI
Component/s: content app
Affects Version/s: 5.2.2
Fix Version/s: 5.3.5

Type: Bug Priority: Neutral
Reporter: Rainer Blumenthal Assignee: Christopher Zimmermann
Resolution: Fixed Votes: 0
Labels: choosedialog, support
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Attachments: JPEG File screenshot-1.jpg     JPEG File screenshot-2.jpg     JPEG File screenshot-3.jpg    
Issue Links:
Relates
relates to MGNLUI-3197 Multi link field: support for multi-s... Closed
Template:
Acceptance criteria:
Empty
Task DoD:
[ ]* Doc/release notes changes? Comment present?
[ ]* Downstream builds green?
[ ]* Solution information and context easily available?
[ ]* Tests
[ ]* FixVersion filled and not yet released
[ ]  Architecture Decision Record (ADR)
Bug DoR:
[ ]* Steps to reproduce, expected, and actual results filled
[ ]* Affected version filled
Release notes required:
Yes
Date of First Response:
Visible to:
Frank Sommer, Oliver Emke

 Description   

Since the actual mechanism in the Choose dialog does not support multiple selection, the UI should reflect this by removing checkboxes (which imply multiple selection), and only hilight a row upon click.
Eventually we must improve choose dialogs to support multiple selection - see related ticket MGNLUI-3197

Use case, Illustration of problem:
I try to add an item to a set of items using a default Magnolia control.

Please see screenshot.

1. Click "Add"
2. Choose 2 items
3. Save

--> only one item is chosen - this is completely misleading. I was so happy to be able to choose multiple items ;



 Comments   
Comment by Frank Sommer [ 05/Mar/14 ]

The LinkFieldDefinition opens the choose dialog of the destination app. The behavior of multiple selection is not defined. Perhaps this should be disabled in the choose dialog.

Comment by Christopher Zimmermann [ 15/Oct/14 ]

Multiple selection disabled in ChooseDialog UIs. Added multipleSelection property to WorkbenchDefinition. This is set to false in ContentApp when default choose dialogs are created. Value is applied to Vaadin table components via WorkbenchView#setMultiselect in WorkbenchPresenter.

Reviewer: Please see UI test at https://git.magnolia-cms.com/gitweb/?p=ce-bundle.git;a=commit;h=14eafe330f882dcb2689b9048e360cf47744a23a

Comment by Christopher Zimmermann [ 20/Oct/14 ]

Removed isMultipleSelection from WorkbenchDefinition and use isDialogWorkbench to determine when to dissallow multiple selection.

Generated at Mon Feb 12 08:59:35 CET 2024 using Jira 9.4.2#940002-sha1:46d1a51de284217efdcb32434eab47a99af2938b.