[MGNLUI-2739] Compilation errors when building magnolia-ui-vaadin-common-widgets using Maven 3 Created: 11/Mar/14 Updated: 27/Aug/14 Resolved: 27/Aug/14 |
|
| Status: | Closed |
| Project: | Magnolia UI |
| Component/s: | build |
| Affects Version/s: | 5.2.x, 5.3 |
| Fix Version/s: | None |
| Type: | Bug | Priority: | Neutral |
| Reporter: | Peter Phillips | Assignee: | Mikaël Geljić |
| Resolution: | Obsolete | Votes: | 0 |
| Labels: | None | ||
| Remaining Estimate: | Not Specified | ||
| Time Spent: | Not Specified | ||
| Original Estimate: | Not Specified | ||
| Environment: |
Apache Maven 3.2.1 |
||
| Attachments: |
|
| Template: |
|
| Patch included: |
Yes
|
| Acceptance criteria: |
Empty
|
| Task DoD: |
[ ]*
Doc/release notes changes? Comment present?
[ ]*
Downstream builds green?
[ ]*
Solution information and context easily available?
[ ]*
Tests
[ ]*
FixVersion filled and not yet released
[ ] 
Architecture Decision Record (ADR)
|
| Bug DoR: |
[ ]*
Steps to reproduce, expected, and actual results filled
[ ]*
Affected version filled
|
| Date of First Response: |
| Description |
|
magnolia-ui-vaadin-common-widgets within magnolia_ui.pub doesn't compile using Maven 3 due to the groovy rename of patched java files not being executed. Looking at the pom there are two groovy-maven-plugin declarations. Maven ignores the first declaration and so only then executes the second plugin. Instead of two separate declarations of the plugin there should be two separate executions within a single plugin declaration. Please find attached a patch to the pom which fixes the issue. Note that this issue does not occur with Maven 2, but the project will still build in Maven 2 after the patch is applied. |
| Comments |
| Comment by Mikaël Geljić [ 27/Aug/14 ] |
|
Hi Peter, Actually we no longer have double declarations for the groovy maven plugin since April or so (basically I had removed Sass compilation from this module; ui-admincentral is currently the only module where we need it). Nonetheless, thanks for spotting it/apologies for the delayed reply! Please do report if you still encounter issues when compiling with Maven 3. |