[MGNLUI-2744] Page editor: all links outside of navigation can't be followed in preview mode Created: 14/Mar/14  Updated: 05/Dec/14  Resolved: 22/Sep/14

Status: Closed
Project: Magnolia UI
Component/s: page editor
Affects Version/s: 5.0
Fix Version/s: 5.4

Type: Bug Priority: Major
Reporter: Zdenek Skodik Assignee: Espen Jervidalo
Resolution: Fixed Votes: 0
Labels: support
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Attachments: PNG File Screen Shot 2014-09-22 at 17.04.47.png    
Issue Links:
causality
duplicate
is duplicated by MGNLSTK-1372 Preview of a page using a redirect te... Closed
is duplicated by MGNLUI-2768 Can't open external link to Google in... Closed
relation
is related to MGNLUI-511 page editor: links inside page editor... Closed
is related to MGNLUI-1206 page editor: links outside navigation... Closed
is related to MGNLUI-2746 pages app doesn't catch all page changes Closed
Template:
Acceptance criteria:
Empty
Task DoD:
[ ]* Doc/release notes changes? Comment present?
[ ]* Downstream builds green?
[ ]* Solution information and context easily available?
[ ]* Tests
[ ]* FixVersion filled and not yet released
[ ]  Architecture Decision Record (ADR)
Bug DoR:
[ ]* Steps to reproduce, expected, and actual results filled
[ ]* Affected version filled
Date of First Response:

 Description   

There are still two use cases making the PageEditor to behave inconsistent when it comes to links in preview mode:

  • internal links with target="_blank" used to be opened by the page editor inside the editing frame, even though target="_blank" should open the links in a new tab or new window.
  • external links are not opened at all.


 Comments   
Comment by Chunhua Liu [ 15/Apr/14 ]

For all links outside of navigation.
Because link's target property default is "_self",
so if link don't have target or target equals "_self" , and then if link is internal link we will attach that js function,
otherwise keeping link's default behaviour.

Comment by Espen Jervidalo [ 17/Apr/14 ]

We will have to postpone this fix. We are aware of the limitations caused by the link handling inside the page editor and have been discussing the issue internally and will try to come up with a satisfactory solution as soon as possible.

Comment by Philipp Bärfuss [ 16/Jun/14 ]

We fix this after the 5.3 release when we have time to think the solution through.

I could imagine to open a new browser window after showing a confirmation dialog which informs the user about that fact. If we run into browser policies limitations (onclick not allowed to open a tab) we could consider rendering a clickable link in that light dialog.

Comment by Espen Jervidalo [ 22/Sep/14 ]

Based on fix provided by MGNLUI-2746, this ticket is now resolved. The changes won't make it in before 5.4 IMO. New behavior:
in preview:

  • target="_blank" opens a new browser tab as expected.
  • other links are blindly followed, but do not break the page editor: external pages are displayed inside the iframe, but it is indicated in the pagebar (see screenshot) and furthermore, all controls, like actionbar, langauge- and platform-selectors are disabled.
Generated at Mon Feb 12 08:59:43 CET 2024 using Jira 9.4.2#940002-sha1:46d1a51de284217efdcb32434eab47a99af2938b.