[MGNLUI-2751] As a user I can adjust my preferences / settings Created: 07/Jan/14  Updated: 29/Oct/15  Resolved: 17/Apr/14

Status: Closed
Project: Magnolia UI
Component/s: None
Affects Version/s: 5.0
Fix Version/s: 5.2.4

Type: Improvement Priority: Critical
Reporter: Natascha Desmarais Assignee: Eric Hechinger
Resolution: Fixed Votes: 0
Labels: admincentral, maintenance, support, ux
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Issue Links:
dependency
depends upon MGNLUI-2752 SystemLanguagesFieldDefinition doesn'... Closed
Template:
Acceptance criteria:
Empty
Task DoD:
[ ]* Doc/release notes changes? Comment present?
[ ]* Downstream builds green?
[ ]* Solution information and context easily available?
[ ]* Tests
[ ]* FixVersion filled and not yet released
[ ]  Architecture Decision Record (ADR)
Release notes required:
Yes
Date of First Response:

 Description   

In 4.5 it was possible as a user to change my own settings such as language, email, password from a popup window that was accessible when logged in and clicking on the username.



 Comments   
Comment by Mikaël Geljić [ 20/Mar/14 ]

First comments from review:

  • Action name should be "Edit user profile"
  • Edit dialog title is missing (missing key ui-admincentral.editUserProfile.label=Edit user profile)

Also checking today whether or not we want to use icons for the user menu.
Site note: I have these changes ready locally.

Comment by Roman Kovařík [ 01/Apr/14 ]
  1. Could you group all related update tasks into ArrayDelegateTask so it's obvious that it belongs together?
  2. Could we preserve also the old method to preserve binary compatibility?:
    info.magnolia.ui.admincentral.usermenu.UserMenuView.addAction(String, String) -> addAction(String, String, String)
Comment by Roman Kovařík [ 03/Apr/14 ]

Commit:
https://git.magnolia-cms.com/gitweb/?p=magnolia_ui.git;a=commitdiff;h=0cdce9991523934c2b46410f4d4ff9b71ad809a7

Comment by Christoph Meier [ 15/Apr/14 ]

If the pwd (password) is changed/saved using the security-app (as superuser), the password is stored not in plain-txt (but its MD5 ... i guess).
If the pwd is stored with the new dialog, it goes as plain-txt into the repo.

Comment by Christoph Meier [ 16/Apr/14 ]

Added a custom action info.magnolia.ui.admincentral.dialog.action.EditUserProfileAction.
Some of the code is copied from info.magnolia.security.app.dialog.action.SaveUserDialogAction. While SaveUserDialogAction allows to edit every user,
EditUserProfileAction is restricted to edit properties of the currently logged-in user; having said this it's okay to have 2 separate classes.

Comment by Christoph Meier [ 16/Apr/14 ]

Note, that the fix is on https://git.magnolia-cms.com/gitweb/?p=magnolia_ui.git;a=commit;h=12bf7c5ac65b5152bd000edbc85ff1d3438ea984
which is on branch MGNLUI-2751-b .
Earlier changes done on "MGNLUI-2751"-branch alre already on 5.2.x

Comment by Eric Hechinger [ 16/Apr/14 ]

Glad if you could add a unit test for the new action

Comment by Milan Divilek [ 16/Apr/14 ]

Last implementation doesn't allow to add custom fields to editUserProfile dialog. Custom fields will not be saved by this action. This would be regression from 4.5.

Generated at Mon Feb 12 08:59:48 CET 2024 using Jira 9.4.2#940002-sha1:46d1a51de284217efdcb32434eab47a99af2938b.