[MGNLUI-276] Do not show inline help messages and dialog descriptions if they are empty Created: 29/Aug/12 Updated: 11/Feb/13 Resolved: 31/Dec/12 |
|
| Status: | Closed |
| Project: | Magnolia UI |
| Component/s: | design, dialogs, forms |
| Affects Version/s: | None |
| Fix Version/s: | 5.0 |
| Type: | Bug | Priority: | Major |
| Reporter: | Federico Grilli | Assignee: | Christopher Zimmermann |
| Resolution: | Fixed | Votes: | 1 |
| Labels: | frontend | ||
| Remaining Estimate: | Not Specified | ||
| Time Spent: | Not Specified | ||
| Original Estimate: | Not Specified | ||
| Attachments: |
|
||||||||||||
| Issue Links: |
|
||||||||||||
| Template: |
|
||||||||||||
| Acceptance criteria: |
Empty
|
||||||||||||
| Task DoD: |
[ ]*
Doc/release notes changes? Comment present?
[ ]*
Downstream builds green?
[ ]*
Solution information and context easily available?
[ ]*
Tests
[ ]*
FixVersion filled and not yet released
[ ] 
Architecture Decision Record (ADR)
|
||||||||||||
| Bug DoR: |
[ ]*
Steps to reproduce, expected, and actual results filled
[ ]*
Affected version filled
|
||||||||||||
| Date of First Response: | |||||||||||||
| Description |
|
Attached screenshot showing the case in question. I think it would make sense not displaying any clickable help icon or dialog description when those are empty. |
| Comments |
| Comment by Andreas Weder [ 24/Oct/12 ] |
|
Bumping the priority since this is quite ugly and leads to always weird effects in demos and presentations. Help should be available only, if there's actually some text. |
| Comment by Andreas Weder [ 03/Dec/12 ] |
|
Added component(s) to make it easier to filter issues. |
| Comment by Christopher Zimmermann [ 31/Dec/12 ] |
|
For the form/dialog description modified VformHeader and VDialogHeader. I simply dont show the description if there is not one. I left the button in place at the top of the form/dialog, because at this stage I think it would be difficult to determine if none of the fields had a description as well. For the form fields, there was already a test for description being null, I added a test for description = "", which helped on the Page Properties form dialog. (in FormFieldWrapper) |