[MGNLUI-2784] Fix jar plugin configuration of magnolia-ui-vaadin-common-widgets and magnolia-ui-widget-editor Created: 31/Mar/14 Updated: 08/Aug/14 Resolved: 14/Apr/14 |
|
| Status: | Closed |
| Project: | Magnolia UI |
| Component/s: | None |
| Affects Version/s: | None |
| Fix Version/s: | 5.2.4 |
| Type: | Bug | Priority: | Critical |
| Reporter: | Magnolia International | Assignee: | Magnolia International |
| Resolution: | Fixed | Votes: | 0 |
| Labels: | None | ||
| Remaining Estimate: | Not Specified | ||
| Time Spent: | Not Specified | ||
| Original Estimate: | Not Specified | ||
| Issue Links: |
|
||||
| Template: |
|
||||
| Acceptance criteria: |
Empty
|
||||
| Task DoD: |
[ ]*
Doc/release notes changes? Comment present?
[ ]*
Downstream builds green?
[ ]*
Solution information and context easily available?
[ ]*
Tests
[ ]*
FixVersion filled and not yet released
[ ] 
Architecture Decision Record (ADR)
|
||||
| Bug DoR: |
[ ]*
Steps to reproduce, expected, and actual results filled
[ ]*
Affected version filled
|
||||
| Date of First Response: | |||||
| Description |
|
The pom files of these 2 modules currently configures maven-jar-plugin to generate an INDEX.LIST which is turn causing some build issues on some platforms. There is no reason for these jar entries to be there, and that configuration seems to have been copy-paste accidentally from some example. (AFAICT, it's been introduced in the m5-vaadin prototype, with m5-magnolia-shell in commit 118311761ba, and copied over multiple places since - and that in turn seems to come from the Vaadin-widget-project Maven archetype) It should look like this: <plugin>
<groupId>org.apache.maven.plugins</groupId>
<artifactId>maven-jar-plugin</artifactId>
<configuration>
<archive>
<!-- Remove this line: <index>true</index>-->
<manifest>
<!-- Remove this line: <addClasspath>true</addClasspath> -->
<addDefaultImplementationEntries>true</addDefaultImplementationEntries>
</manifest>
<manifestEntries>
<Vaadin-Package-Version>1</Vaadin-Package-Version>
<Vaadin-Widgetsets>
info.magnolia.ui.vaadin.editor.gwt.PageEditorWidgetSet
</Vaadin-Widgetsets>
</manifestEntries>
</archive>
</configuration>
</plugin>
(i.e remove <index> as well as <addClasspath>, which makes no sense for us either) This seems to fix issues with running integration tests on different machines (specifically, the issue where jsp compilation, for some reason, triggered {{InvalidJarIndexException}}s), so should allow our build infrastructure to grow faster, once fixed. |
| Comments |
| Comment by Magnolia International [ 31/Mar/14 ] |
|
Indeed, com.vaadin:vaadin-archetype-widget configures pom.xml with the above. apchelintcev tries to get some information as to why Vaadin does this. |
| Comment by Magnolia International [ 31/Mar/14 ] |
|
Have local fix, keeping it open for a bit to see if we hear back from Vaadin folks |
| Comment by Magnolia International [ 01/Apr/14 ] |
|
See discussion on Vaadin forum for follow-up : https://vaadin.com/forum/#!/thread/5162993 |
| Comment by Magnolia International [ 14/Apr/14 ] |
|
Done on master and 5.2.x branch; since there was no visible side-effect for 2 weeks while on master, nor feedback on the Vaadin forum, we assume this is OK. |
| Comment by Pete Ryland [ 08/Aug/14 ] |
|
This appears still to be affecting magnolia-bundle_5.0.x-with-selenium_profile but not magnolia-bundle_5.1.x-with-selenium_profile. |
| Comment by Magnolia International [ 08/Aug/14 ] |
|
Cherry-picked d05141da055d4c591c9bfdb6373d0e9172b68c0f onto 5.0.x and 5.1.x in the hope of fixing those jobs so we can get on with SYS-467 and SYS-586 |